Re-enable win32 pull-testing #3060

pull gavinandresen wants to merge 2 commits into bitcoin:master from gavinandresen:pulltestwin32 changing 2 files +14 −11

gavinandresen commented at 3:12 AM on October 7, 2013: contributor

I'm working on re-enabling pull-tester do mingw builds this afternoon.

No need to ACK this, I'll pull it when it works.

Bitcoin-Qt: prevent stuck/unusable debug window on exit

- when closing the client with an open debug window, that window could
  become stuck/unsuable (it was still shown wherea the main window was
  hidden already)
- fix this by hiding the debug window, when quitting the the client

910e889c71

Re-enable win32 pull-testing a6ff5cd754
in qa/pull-tester/build-tests.sh.in:None in 1a9300c3c4 outdated
```
  21 | +cd @abs_top_srcdir@
  22 | +make distdir
  23 | +mv $DISTDIR win32-build
  24 | +cd win32-build
  25 | +./configure --disable-silent-rules --disable-ccache --prefix=$MINGWPREFIX --host=i586-mingw32msvc --with-qt-bindir=$MINGWPREFIX/host/bin --with-qt-plugindir=$MINGWPREFIX/plugins --with-qt-incdir=$MINGWPREFIX/include --with-boost=$MINGWPREFIX --with-protoc-bindir=$MINGWPREFIX/host/bin CPPFLAGS=-I$MINGWPREFIX/include LDFLAGS=-L$MINGWPREFIX/lib
  26 | +make -j$JOBS
```
sipa commented at 11:55 AM on October 7, 2013:

Doesn't this already imply doing a check?

gavinandresen commented at 1:35 PM on October 7, 2013:

You mean the 'make check' ? Yes, that runs the Qt and bitcoind unit tests. But since the ./configure line doesn't include --with-comparison-tool, the blockchain tester isn't run on the windows binary.

I'm not sure why, but running the windows executable against the blockchain tester resulted in a never-finishing test. Something to investigate and fix when the blockchain tester is updated to latest&greatest....

sipa commented at 1:48 PM on October 7, 2013:

Never mind; I thought make implied make check, but I'm wrong.
BitcoinPullTester commented at 12:36 AM on October 8, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a6ff5cd7541f420a8e7bc74f7514f163ac3900ed for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
gavinandresen commented at 1:08 AM on October 8, 2013: contributor

Merged.
gavinandresen closed this on Oct 8, 2013
gavinandresen deleted the branch on Oct 8, 2013
Bushstar referenced this in commit 9d2d8ccede on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

gavinandresen

sipa

BitcoinPullTester