use MiniWallet in functional test rpc_signrawtransactionwithkey.py for funding txs #30600

issue theStack openend this issue on August 7, 2024
  1. theStack commented at 1:35 pm on August 7, 2024: contributor

    Motivation

    The functional test rpc_signrawtransactionwithkey.py currently creates funding transactions by spending the coinbases of newly mined blocks, which is rather slow and leads to unnecessary complex code (see method send_to_address). It would be simpler to use a MiniWallet instance for that purpose, in combination with the pre-generated test chain which already contains UTXOs for MiniWallet’s default mode ADDRESS_OP_TRUE. That way, the test code is not cluttered with low-level tx details of funding tx creation and more readable. While touching the test, other small improvements could be considered as well (e.g. do we really need spin up two different nodes to achieve our testing goals?).

    Possible solution

    No response

    Useful Skills

    • Basic Python 3 skills
    • Basic understanding of transactions, difference between output scripts and addresses
    • Being familiar with MiniWallet’s capabilities (how to send funds to an arbitrary output script?)

    Guidance for new contributors

    Want to work on this issue?

    For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

  2. theStack added the label good first issue on Aug 7, 2024
  3. allanperlee commented at 10:50 pm on August 10, 2024: none
    Hi @theStack, I could soon start this issue
  4. martinsaposnic referenced this in commit 1e63efd7a1 on Aug 22, 2024
  5. martinsaposnic commented at 9:55 pm on August 22, 2024: contributor
    new possible solution for this issue: #30701 🙂
  6. martinsaposnic referenced this in commit 51b7e9a326 on Aug 22, 2024
  7. martinsaposnic referenced this in commit 8bd447202c on Aug 22, 2024
  8. glozow referenced this in commit 7349d572c3 on Aug 29, 2024
  9. maflcko closed this on Aug 30, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me