refactor: Migrate EmplaceCoinInternalDANGER to try_emplace #30637

pull l0rinc wants to merge 1 commits into bitcoin:master from l0rinc:l0rinc/try_emplace changing 1 files +1 −4
  1. l0rinc commented at 3:43 pm on August 12, 2024: contributor

    Leftover from #28280 (review):

    try_emplace doc states

    1. Behaves like emplace except that the element is constructed as value_type(std::piecewise_construct, std::forward_as_tuple(std::move(k)), std::forward_as_tuple(std::forward(args)…))

    The DANGER part in the method’s name refers to:

    NOT FOR GENERAL USE

  2. Migrate EmplaceCoinInternalDANGER to try_emplace
    https://en.cppreference.com/w/cpp/container/map/try_emplace states
    > 2) Behaves like emplace except that the element is constructed as
    value_type(std::piecewise_construct,
               std::forward_as_tuple(std::move(k)),
               std::forward_as_tuple(std::forward<Args>(args)...))
    
    The DANGER part in the method's name refers to
    https://github.com/bitcoin/bitcoin/pull/19806/commits/f6e2da5fb7c6406c37612c838c998078ea8d2252#diff-095ce1081a930998a10b37358fae5499ac47f8cb6f25f5df5d88e920a54e0341R272 i.e.:
    > NOT FOR GENERAL USE
    aea6202dcc
  3. DrahtBot commented at 3:43 pm on August 12, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. DrahtBot added the label Refactoring on Aug 12, 2024
  5. l0rinc marked this as ready for review on Aug 12, 2024
  6. l0rinc closed this on Sep 9, 2024

  7. l0rinc deleted the branch on Sep 9, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me