kernel: pre-28.x chainparams and headerssync update #30658

1. 
   achow101 commented at 6:05 pm on August 14, 2024: member

   Update chainparams and headerssync parameters for the pre-28.x branching, per https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#before-branch-off
2. 
   DrahtBot commented at 6:05 pm on August 14, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fjahr, Sjors, glozow, marcofleon

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #27433 (getblocktemplate improvements for segwit and sigops by Sjors)
   • #26201 (Remove Taproot activation height by Sjors)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. achow101 added this to the milestone 28.0 on Aug 14, 2024
4. DrahtBot added the label Validation on Aug 14, 2024
5. in src/kernel/chainparams.cpp:253 in 985d1ec267 outdated

   249@@ -250,7 +250,7 @@ class CTestNetParams : public CChainParams {
   250         nDefaultPort = 18333;
   251         nPruneAfterHeight = 1000;
   252         m_assumed_blockchain_size = 42;
   253-        m_assumed_chain_state_size = 3;
   254+        m_assumed_chain_state_size = 11;
   

   ---

   ---

   

   Sjors commented at 12:12 pm on August 15, 2024:

   985d1ec267f44b7897855fd2312da76b3fcd165b: this is already 13G for me.

   ---

   

   achow101 commented at 2:42 pm on August 15, 2024:

   It’s 9.9G for me. Are you looking at the right network datadir?

   ---

   

   Sjors commented at 3:01 pm on August 15, 2024:

   0$ du -h ~/.bitcoin/testnet3
   113G	/home/sjors/.bitcoin/testnet3/chainstate
   2103G	/home/sjors/.bitcoin/testnet3
   

   ---

   

   achow101 commented at 3:05 pm on August 15, 2024:

   Hmm, that’s odd. Across 3 of my nodes, it’s 9.9G

   0$ du -sh ~/.bitcoin/testnet3/chainstate/ ~/.bitcoin/testnet3/blocks/
   19.9G	/home/ava/.bitcoin/testnet3/chainstate/
   239G	/home/ava/.bitcoin/testnet3/blocks/
   

   ---

   

   mzumsande commented at 7:58 pm on August 15, 2024:

   I see similar size to @Sjors, as of height=2873716:

   0du -sh ~/.bitcoin/testnet3/chainstate/ ~/.bitcoin/testnet3/blocks/
   113G	/home/martin/.bitcoin/testnet3/chainstate/
   282G	/home/martin/.bitcoin/testnet3/blocks/
   

   ---

   

   fjahr commented at 11:46 am on August 16, 2024:

   I raise you 17G! (height 2873788)

   0$ du -sh /Volumes/PortableSSD/datadir/testnet3/chainstate/ /Volumes/PortableSSD/datadir/testnet3/blocks/
   1 17G	/Volumes/PortableSSD/datadir/testnet3/chainstate/
   2 82G	/Volumes/PortableSSD/datadir/testnet3/blocks/
   

   I know LevelDB can cause some differences in size on disk but this seems extreme…

   ---

   

   fjahr commented at 11:58 am on August 16, 2024:

   Either way, m_assumed_blockchain_size can be updated here too.

   ---

   

   0xB10C commented at 1:36 pm on August 16, 2024:

   0$ du -sh blocks/ chainstate/
   184G	blocks/
   213G	chainstate/
   

   ---

   

   achow101 commented at 3:22 pm on August 16, 2024:

   I’m quite confused as to how all of you have way larger blocks and chainstate dirs than I do. I checked my 3 nodes and they all agree on these sizes, and all 3 have very high uptimes.

   Anyways, bumped m_assumed_blockchain_size to 93 and m_assumed_chain_state_size to 19, which I think should cover all sizes given here.

6. Sjors approved
7. 
   Sjors commented at 12:27 pm on August 15, 2024: member

   ACK cd913de6488d25057e3bf7dcad1508e9d689f87f

   If you have to touch, can you make contrib/devtools/headerssync-params.py executable?

8. 
   fjahr commented at 12:45 pm on August 16, 2024: contributor

   ACK cd913de6488d25057e3bf7dcad1508e9d689f87f

   Aside from the size-on-disk weirdness discussed above, I have compared all the values to my local nodes in the different networks and got matches each time. I also executed contrib/devtools/headerssync-params.py locally and got the same results.

9. params: Update assumed blockchain and chainstate sizes 6a5bdae322
10. params: Update chainTxData 255d4514d3
11. params: Update assumevalid and minimum chainwork c2707446f7
12. achow101 force-pushed on Aug 16, 2024
13. headerssync: Update headerssync configuration 221809b81c
14. achow101 force-pushed on Aug 16, 2024
15. 
    achow101 commented at 3:23 pm on August 16, 2024: member

    If you have to touch, can you make contrib/devtools/headerssync-params.py executable?

    Done

16. 
    fjahr commented at 3:35 pm on August 16, 2024: contributor

    re-ACK 221809b81cfcecb04050915eebacffda2599da42

    Only changes since last review were bumping the Testnet3 size numbers and making headerssync-params.py executable.

    https://github.com/bitcoin/bitcoin/compare/cd913de6488d25057e3bf7dcad1508e9d689f87f..221809b81cfcecb04050915eebacffda2599da42

17. DrahtBot requested review from Sjors on Aug 16, 2024
18. 
    Sjors commented at 6:49 am on August 17, 2024: member

    re-ACK 221809b81cfcecb04050915eebacffda2599da42
19. 
    glozow commented at 2:27 pm on August 22, 2024: member

    ACK 221809b81cfcecb04050915eebacffda2599da42

    Checked chain params against my nodes (all except testnet3, I just sanity checked that against a block explorer). Checked I get the same headerssync params.

20. 
    marcofleon commented at 3:41 pm on August 22, 2024: contributor

    ACK 221809b81cfcecb04050915eebacffda2599da42

    Headerssync params lgtm, got the same ones. I checked the main chain params against my node and the only thing is that my blocks dir is 675 gbs, not 620. Not sure if it matters too much.

21. glozow merged this on Aug 22, 2024
22. glozow closed this on Aug 22, 2024

    ---

23. 
    tdb3 commented at 5:24 pm on August 22, 2024: contributor

    post merge ACK 221809b81cfcecb04050915eebacffda2599da42

    Checked chainparams (mainnet and signet) manually on each of my nodes. Matched.

    0$ bitcoin-cli getblockhash 856760
    1$ bitcoin-cli getchaintxstats 4096 <block hash from getblockhash>
    2$ bitcoin-cli getblockheader <block hash from getblockhash>
    3$ bitcoin-cli -signet getblockhash 208800
    4$ bitcoin-cli -signet getchaintxstats 4096 <block hash from getblockhash>
    5$ bitcoin-cli -signet getblockheader <block hash from getblockhash>
    

Contributors
achow101 DrahtBot Sjors mzumsande fjahr 0xB10C glozow marcofleon tdb3

Review Requested
Sjors

Labels
Validation

Milestone
28.0