Split socket handling out of CConnman #30694

1. 
   vasild commented at 9:53 am on August 22, 2024: contributor

   Please describe the feature you’d like to see added.

   Split CConnman in two pieces:

   • protocol agnostic low level socket and connection handler and
   • bitcoin-p2p protocol specific handler.

   This way the first part can be reused for Stratum V2 and for libevent-less RPC/HTTP server.

   Is your feature related to a problem, if so please describe it.

   Doing Stratum V2 and removing libevent from RPC requires duplicating some of the code from CConnman - binding and listening and the send/recv io loop.

   Describe the solution you’d like

   Split CConnman in such a way that the code can be reused.

   Describe any alternatives you’ve considered

   Duplicate code.

2. vasild added the label Feature on Aug 22, 2024
3. 
   vasild commented at 9:55 am on August 22, 2024: contributor

   I am looking into doing this.

   cc @Sjors, @pinheadmz

4. 
   pinheadmz commented at 10:17 am on August 22, 2024: member

   I am looking into doing this.

   Wow thanks! My HTTP branch is almost done but is very messy. You can see me copy/paste/edit socket handling in

   https://github.com/pinheadmz/bitcoin/blob/http-netbase/src/http.cpp GenerateEventsPerSock() HandleConnections() AcceptConnections() etc…

5. 
   vasild commented at 7:58 am on September 27, 2024: contributor

   Done in #30988.

Contributors
vasild pinheadmz

Labels
Feature