test: Avoid intermittent block download timeout in p2p_ibd_stalling #30705

1. 
   maflcko commented at 3:52 pm on August 23, 2024: member

   Fixes #30704

   The goal of the test is to check the stalling timeout, not the block download timeout.

   On extremely slow hardware (for example qemu virtual hardware), downloading the 1023 blocks may take longer than the block download timeout.

   Fix it by pinning the time using mocktime, and only advance it when testing the stalling timeout.

2. test: Avoid intermittent block download timeout in p2p_ibd_stalling fa5b58ea01
3. 
   DrahtBot commented at 3:52 pm on August 23, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	tdb3, brunoerg

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Aug 23, 2024
5. tdb3 approved
6. 
   tdb3 commented at 0:32 am on August 25, 2024: contributor

   CR ACK fa5b58ea01fac1adb6336b8b6b5217193295c695
7. brunoerg approved
8. 
   brunoerg commented at 12:45 pm on August 26, 2024: contributor

   utACK fa5b58ea01fac1adb6336b8b6b5217193295c695
9. fanquake merged this on Aug 27, 2024
10. fanquake closed this on Aug 27, 2024

    ---

11. maflcko deleted the branch on Aug 27, 2024

Contributors
maflcko DrahtBot tdb3 brunoerg

Labels
Tests