Remove include of windows.h from allocators.h #3071

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:windows_h changing 3 files +68 −54

gavinandresen commented at 6:50 AM on October 9, 2013: contributor
Create an allocators.cpp, and move all of the #ifdef WIN32 code and the #include of windows.h into it.

Two motives for this cleanup:
1. I'm getting a weird error in windows.h in my smartfee branch.
2. allocators.h is included (indirectly) just about everywhere, so this should speed up Windows compiles quite a lot.

Remove include of windows.h from allocators.h

Create an allocators.cpp, and move all of the #ifdef WIN32
code and the #include of windows.h into it.

Two motives for this cleanup:
1. I'm getting a weird error in windows.h in my smartfee branch.
2. allocators.h is included (indirectly) just about everywhere, so
this should speed up Windows compiles quite a lot.

d8315d1650

laanwj commented at 7:30 AM on October 9, 2013: member

ACK
BitcoinPullTester commented at 5:34 AM on October 11, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d8315d1650373e6609cfda921160fd51f6608a99 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 10:18 AM on October 11, 2013: none

Seems reasonable and passes tests, get it in :).
laanwj referenced this in commit 56c0ba7a0f on Oct 11, 2013
laanwj merged this on Oct 11, 2013
laanwj closed this on Oct 11, 2013
gavinandresen deleted the branch on Nov 4, 2013
MathyV referenced this in commit bbcccc0761 on Jun 20, 2014
MathyV referenced this in commit 1513bef38a on Jul 31, 2014
MathyV referenced this in commit 748ad0bef2 on Jul 31, 2014
MathyV referenced this in commit 71acc808f1 on Aug 3, 2014
MathyV referenced this in commit 906ffb5618 on Aug 5, 2014
Bushstar referenced this in commit 3d5eabcfbb on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#3081 prevent compiler redefinition warnings #32089 Failure to run Fuzz tests when running with corpus