doc: fix compiler flags for macOS configuration #30785

pull marcofleon wants to merge 1 commits into bitcoin:master from marcofleon:2024/09/macOS-doc-fix changing 1 files +1 −1
  1. marcofleon commented at 11:58 am on September 2, 2024: contributor

    Small CMake correction in the macOS build docs. My Mac will actually use AppleClang if I don’t specify the compiler flags.

    0% cmake -B testbuild
    1-- The CXX compiler identification is AppleClang 15.0.0.15000309
    
    0% cmake -B testbuild -DCMAKE_C_COMPILER="$(brew --prefix llvm)/bin/clang" -DCMAKE_CXX_COMPILER="$(brew --prefix llvm)/bin/clang++"
    1-- The CXX compiler identification is Clang 18.1.8
    
  2. doc: fix compiler flags for macOS configuration 8d7f8fabae
  3. in doc/build-osx.md:60 in 8d7f8fabae
    59@@ -60,7 +60,7 @@ brew install llvm
    60 And append the following to the configure commands below:
    


    brunoerg commented at 12:08 pm on September 2, 2024:
    Perhaps this phrase should be changed as well since there is no configure command anymore?

    marcofleon commented at 1:12 pm on September 2, 2024:
    The word “confgure” is still used in all the build docs to describe that step (not just mac), so I’ll leave that as is. Maybe another PR can reword the descriptions if we want to do that.
  4. brunoerg approved
  5. brunoerg commented at 1:16 pm on September 2, 2024: contributor
    ACK 8d7f8fabae252710e8e43bf18a0c33ec9f8a7137
  6. maflcko commented at 1:17 pm on September 2, 2024: member
    review ACK 8d7f8fabae252710e8e43bf18a0c33ec9f8a7137
  7. fanquake merged this on Sep 2, 2024
  8. fanquake closed this on Sep 2, 2024

  9. marcofleon deleted the branch on Sep 17, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-20 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me