Unify -logsourcelocations format #30799

issue maflcko openend this issue on September 3, 2024
  1. maflcko commented at 3:21 pm on September 3, 2024: member

    Now that cmake requires out-of-tree builds, it would be nice to unify the -logsourcelocations output format.

    Currently, with cmake, it includes the src, which seems redundant and doesn’t match the guix builds.

    Out-of-tree builds were always broken in this regard, but now would probably be a good time to unify it to drop the src prefix in logsourcelocations, so that it matches: (1) legacy-autotools-in-tree behavior (2) legacy- and cmake-guix build behavior.

    Ref:

    0$ ./bld-cmake/src/bitcoind -printtoconsole -logsourcelocations -asmap=/tmp/no_file 
    12024-08-23T08:29:32Z [init] [src/init/common.cpp:149] [LogPackageVersion] Bitcoin Core version v27.99.0-41051290ab3b-dirty (release build)
    

    (In all guix builds it would be [init/common.cpp:149])

    This should be possible by applying the appropriate prefix-map, which currently is only applied in guix and when compiling with ccache.

  2. maflcko added the label Build system on Sep 3, 2024
  3. maflcko added the label Utils/log/libs on Sep 3, 2024
  4. fanquake closed this on Nov 6, 2024

  5. fanquake referenced this in commit 85224f92d5 on Nov 6, 2024
  6. fanquake referenced this in commit 144f98db85 on Nov 27, 2024
  7. bitcoin locked this on Nov 6, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-21 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me