Bitcoin-Qt: misc changes for sendcoins and paymentsever #3080

pull Diapolo wants to merge 3 commits into bitcoin:master from Diapolo:sendcoins-paymentreq changing 3 files +21 −16

Diapolo commented at 12:48 PM on October 11, 2013: none
sendcoinsentry: small clear() and setValue() changes
- clear(): clear all UI elements (for secure and insecure payments)
- setValue(): only modify UI elements, which need to be set (for secure or insecure payments)
sendcoinsdialog: display real failed address string
- display the real string (faulty address), which causes the valid address check to fail, instead of a stringified "nonsense" CBitcoinAddress
paymentserver: use own HTML-esc / add new header const
- make processPaymentRequest() use our own HTML-escaping function from GUIUtil
- make string "application/bitcoin-payment" a constant (below similar constant strings in the .cpp file)

sendcoinsentry: small clear() and setValue() changes

- clear(): clear all UI elements (for secure and insecure payments)
- setValue(): only modify UI elements, which need to be set (for secure
  or insecure payments)

057bf35bc5

sendcoinsdialog: display real failed address string

- display the real string (faulty address), which causes the valid address
  check to fail, instead of a stringified "nonsense" CBitcoinAddress

8a041f494f

paymentserver: use own HTML-esc / add new header const

- make processPaymentRequest() use our own HTML-escaping function from
  GUIUtil
- make string "application/bitcoin-payment" a constant (below similar
  constant strings in the .cpp file)

06dfd23d41

BitcoinPullTester commented at 1:14 PM on October 11, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/06dfd23d4106de6672ac451b29ae16c97d7fb76b for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 12:26 PM on October 15, 2013: none

@laanwj Could you check= Should be just a bunch of non-controversial changes :).
laanwj referenced this in commit 38d15d8b42 on Oct 15, 2013
laanwj merged this on Oct 15, 2013
laanwj closed this on Oct 15, 2013
Bushstar referenced this in commit b874fcc8c5 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

BitcoinPullTester