In the developer notes the section on compiling for debug displays outdated instructions that were applicable before the move to cmake build system.
This PR just gives instructions on how to build for debugging in the context of cmake.
In the developer notes the section on compiling for debug displays outdated instructions that were applicable before the move to cmake build system.
This PR just gives instructions on how to build for debugging in the context of cmake.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process.
Type | Reviewers |
---|---|
ACK | tdb3, kevkevinpal, achow101 |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Concept ACK
Looks like the Win64 CI error is unrelated.
🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/29818464464
Make sure to run all tests locally, according to the documentation.
The failure may happen due to a number of reasons, for example:
Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.
ACK 0b003e1
Also in this parity list --enable-debug
is replaced with -DCMAKE_BUILD_TYPE=Debug
and defaults to RelWithDebInfo
https://gist.github.com/hebasto/2ef97d3a726bfce08ded9df07f7dab5e
Also in this parity list
--enable-debug
is replaced with-DCMAKE_BUILD_TYPE=Debug
and defaults toRelWithDebInfo
https://gist.github.com/hebasto/2ef97d3a726bfce08ded9df07f7dab5e
Very helpful link, thanks for sharing!
ACK 0b003e1ff7e09b56cd013b15f1998495994b7211
TIL ccmake
.