dumptxoutset: network is deactivated during the run but re-activated even when an issue was encountered. But it did not cover the case if the user had deactivated the network themselves before. In that case the user may want the network to stay off so the network is not reactivated after dumptxoutset finishes. A test for this behavior is added here.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | pablomartin4btc, theStack, tdb3, achow101 |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
18@@ -19,6 +19,17 @@ def set_test_params(self):
19 self.setup_clean_chain = True
20 self.num_nodes = 1
21
22+ def check_expected_network(self, node, active):
23+ rev_file = node.blocks_path / "rev00000.dat"
24+ bogus_file = node.blocks_path / "bogus.dat"
25+ rev_file.rename(bogus_file)
26+ assert_raises_rpc_error(
nit:
0 self.log.info(f"Test that dumptxoutset with rollback type fails given an invalid height")
1 assert_raises_rpc_error(
run_test. Where it is now it would also be printed twice. Second, the content isn’t right: The reason this fails is not the rollback height, it’s because the rev file can not be read, so the rolling back action failed as in, it could not reach the requested height. But if the re file wasn’t moved above there should be no error raised.
COINBASE_MATURITY = 100), then we are missing testing the rollback type given an invalid height (?).
ParseHashOrHeight() which used in other RPCs and is covered in other tests but still would be good to have it for dumptxoutset. Do you want to open a PR for that @pablomartin4btc ? Otherwise, I can add it here.
tested ACK 72c9a1fe94f927220d3159f516fda684ae9d4caa
Great addition.
Added improper node.setnetworkactive() lines above each call to self.check_expected_network() to ensure the checks would fail. They did (no surprise).
