src/key.h: 207 friend bool operator==(const CKey &a, const CKey &b) { 208 return a.fCompressed == b.fCompressed && memcmp(&a.vch[0], &b.vch[0], 32); 209 }
should compare return value from memcmp with zero.
what's more, to be accurate , this function should return true only when both keys are valid.
Indeed, this should clearly be !memcmp(...). That's quite a sneaky bug.
Phew, luckily the key == functions are not used anywhere. I made CKey:==, CExtPubKey:== and CExtKey:== private and everything still compiles.
Not meant as excuse not to fix this, but at least there's no security problem with the current releases.
^ ^ , I saw many many unused codes in bitcoind, I am rewriting a c++11 version without boost & jsonspirit. hope I can help.