wallet: Fix error messages telling user to specify wallet #30912

1. 
   mzumsande commented at 9:41 pm on September 16, 2024: contributor

   I’m not very familiar with the wallet and got confused by the error messages

   Wallet file not specified (must request wallet RPC through /wallet/<filename> uri-path). Try adding "-rpcwallet=<filename>" option to bitcoin-cli command line.

   not knowing which filename to put here (some wallet.dat in the wallet’s directory?), when actually, at least for newer wallets, just the wallet name is expected.

2. wallet: Fix error messages telling user to specify wallet

   It is not clear which file was meant here.

   4b1935ee50
3. 
   DrahtBot commented at 9:41 pm on September 16, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. DrahtBot added the label Wallet on Sep 16, 2024
5. 
   jonatack commented at 9:48 pm on September 16, 2024: member

   See #26990.
6. 
   mzumsande commented at 9:57 pm on September 16, 2024: contributor

   See #26990.

   Is this related? My problem was that I was asked to provide a filename when in reality a wallet name or maybe directory name is expected. That PR seems to address a different issue?

7. 
   jonatack commented at 9:59 pm on September 16, 2024: member

   Yes, this is a duplicate of the first commit in #26990 (might be good to provide review feedback there).
8. 
   mzumsande commented at 10:39 pm on September 16, 2024: contributor

   How can it be a duplicate if it still says “filename” everywhere after the first commit of #26990? I mean I’m happy to close this trivial PR if #26990 wants to rename that too (if it’s correct to do so) but how can they be duplicates if they do different things?!
9. 
   jonatack commented at 11:03 pm on September 16, 2024: member

   As they both touch the same lines, I thought you may not have been aware of that pull and that the natural course of action would be to leave feedback there rather than both pulls proposing to improve the same message. If you disagree with that I apologize.
10. 
    mzumsande commented at 11:30 pm on September 16, 2024: contributor

    If you disagree with that I apologize.

    I wasn’t aware of the PR and actually agree with that, I just thought (already from the first comment) you wanted to say that the PRs are duplicates, as in addressing the same issue, which they are not.

11. mzumsande closed this on Sep 16, 2024

    ---

12. mzumsande deleted the branch on Sep 17, 2024

Contributors
mzumsande DrahtBot jonatack

Labels
Wallet