ci: Use macos-14 GHA image (x86_64-apple-darwin22.6.0 -> arm64-apple-darwin23.6.0) #30913

1. 
   maflcko commented at 7:42 am on September 17, 2024: member

   There shouldn’t be any downside, because XCode remains pinned to the same version.

   However, builds are expected to be a bit faster with M1, which seems nice.

2. ci: Use macos-14 GHA image fa8f35d786
3. 
   DrahtBot commented at 7:42 am on September 17, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto, willcl-ark

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Sep 17, 2024
5. 
   maflcko commented at 8:10 am on September 17, 2024: member

   Master

   • https://github.com/bitcoin/bitcoin/actions/runs/10895856163/job/30234757205#step:3:12

   0Apple clang version 15.0.0 (clang-1500.0.40.1)
   1Target: x86_64-apple-darwin22.6.0
   2Thread model: posix
   3InstalledDir: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
   

   • https://github.com/bitcoin/bitcoin/actions/runs/10895856163/job/30234757205#step:7:2006: (43 minutes with 21% ccache hit rate)

   Pull

   • https://github.com/bitcoin/bitcoin/actions/runs/10898683046/job/30242410317?pr=30913#step:3:12

   0Apple clang version 15.0.0 (clang-1500.0.40.1)
   1Target: arm64-apple-darwin23.6.0
   2Thread model: posix
   3InstalledDir: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
   

   • https://github.com/bitcoin/bitcoin/actions/runs/10898683046/job/30242410317?pr=30913#step:7:1953: (26 minutes with 0% ccache hit rate)
6. in .github/workflows/ci.yml:77 in fa8f35d786 outdated

   73@@ -74,11 +74,11 @@ jobs:
   74           # Use clang++, because it is a bit faster and uses less memory than g++
   75           git rebase --exec "echo Running test-one-commit on \$( git log -1 ) && CC=clang CXX=clang++ cmake -B build -DWITH_ZMQ=ON -DBUILD_GUI=ON -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWITH_BDB=ON -DWITH_NATPMP=ON -DWITH_MINIUPNPC=ON -DWITH_USDT=ON && cmake --build build -j $(nproc) && ctest --test-dir build -j $(nproc) && ./build/test/functional/test_runner.py -j $(( $(nproc) * 2 ))" ${{ env.TEST_BASE }}
   76 
   77-  macos-native-x86_64:
   78-    name: 'macOS 13 native, x86_64, no depends, sqlite only, gui'
   79+  macos-native-arm64:
   

   ---

   ---

   

   willcl-ark commented at 8:20 am on September 17, 2024:

   This is still building using x86_64-apple-darwin as the host (from 00_setup_env_mac_native.sh). I wonder if the “native” here is therefore confusing?

   ---

   

   maflcko commented at 8:34 am on September 17, 2024:

   That sounds like a bug in the CI config. However, it should be harmless, because HOST is unused (apart from a folder naming), because depends isn’t used here.

   I’ll add an unrelated bugfix commit to remove the wrong config value.

7. 
   willcl-ark commented at 8:23 am on September 17, 2024: member

   Concept ACK.

   Very much in favour of speeding these jobs up! Changes look good to me so far, just one Q on the jobname with this change in architecture.

8. ci: Remove incorrectly hardcoded HOST in mac_native task

   The HOST is wrong, because this is a native build, where the HOST is
   supposed to be auto-detected.

   fab932b421
9. 
   hebasto commented at 9:03 am on September 17, 2024: member

   Concept ACK.

   Perhaps explicitly mention the switch from the x86_64 architecture to arm64?

10. maflcko renamed this:
    ci: Use macos-14 GHA image
    ci: Use macos-14 GHA image (x86_64-apple-darwin22.6.0 -> arm64-apple-darwin23.6.0)
    on Sep 17, 2024
11. 
    maflcko commented at 9:40 am on September 17, 2024: member

    Perhaps explicitly mention the switch from the x86_64 architecture to arm64?

    Sure, done

12. hebasto approved
13. 
    hebasto commented at 11:24 am on September 17, 2024: member

    ACK fab932b4211ea0a4c10e484c08042552f9c58c15.

    We were already using an arm64 CI task before #28187.

14. DrahtBot requested review from willcl-ark on Sep 17, 2024
15. willcl-ark approved
16. 
    willcl-ark commented at 12:09 pm on September 17, 2024: member

    ACK fab932b4211ea0a4c10e484c08042552f9c58c15
17. fanquake merged this on Sep 17, 2024
18. fanquake closed this on Sep 17, 2024

    ---

19. maflcko deleted the branch on Sep 17, 2024

Contributors
maflcko DrahtBot willcl-ark hebasto

Labels
Tests