test: simplify timewarp test #30941

1. 
   tdb3 commented at 2:51 pm on September 21, 2024: contributor

   Follow up from PR #30698 (comment #30698 (review)).

   mining_basic checks that a block with wall time is rejected when the previous block is MAX_FUTURE_BLOCK_TIME in the future, then checks that a block just beyond the MAX_TIMEWARP is also rejected.

   This PR removes the first check, since they seem to be essentially checking the same thing twice. Also incorporates the suggestion in #30698 (review) to reuse block.

2. test: simplify timewarp boundary check in mining_basic

   Removes extraneous wall time check since time
   just beyond timewarp boundary is checked.

   69eae7115d
3. test: reuse block in timewarp check 4631aeb59a
4. 
   DrahtBot commented at 2:51 pm on September 21, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

5. DrahtBot added the label Tests on Sep 21, 2024
6. tdb3 renamed this:
   test: simplify timewarp boundary test
   test: simplify timewarp test
   on Sep 22, 2024

Contributors
tdb3 DrahtBot

Labels
Tests