[qt] using walletpassphrase command in debug console crashes client #3100

issue laanwj opened this issue on October 16, 2013

laanwj commented at 2:29 PM on October 16, 2013: member

At least when -server is not enabled. The following assertion fails:

bitcoin-qt: bitcoinrpc.cpp:900: void RPCRunLater(const string&, boost::function<void()>, int64): Assertion `rpc_io_service != __null' failed.
Aborted (core dumped)

Diapolo commented at 7:48 PM on October 22, 2013: none

@laanwj Is this still the case? AFAIK Gavin recently fixed a RPC shutdown problem related to a NULL pointer.
laanwj commented at 8:22 PM on October 22, 2013: member

Well it was an issue when I tried about a week ago. I don't think anything has changed to the RPC handling since then. You can't reproduce it?
Diapolo commented at 8:50 PM on October 22, 2013: none

Indeed, with server=0 it gives me an assertion in bitcoinrpc.cpp: rpc_io_service != NULL

Caused by RPCRunLater() call in walletpassphrase() (in rpcwallet.cpp), because StartRPCThreads() isn't called when fServer is false, which inits rpc_io_service.
Diapolo commented at 1:20 PM on October 23, 2013: none

@laanwj What is the best way to fix this? Check for fServer in walletpassphrase()? Are there more RPC commands that fail when fServer is false?
laanwj commented at 2:01 PM on October 23, 2013: member

Only walletpassphrase uses RPCRunLater at the moment. So adding a check to that command specifically will do.
laanwj closed this on Oct 24, 2013
luke-jr referenced this in commit a80b01cdf6 on Feb 12, 2014
luke-jr referenced this in commit 7ce5b7b79a on Feb 12, 2014
pooler referenced this in commit 6289b4c46e on Mar 26, 2014
wtogami referenced this in commit 3ea6e729f8 on Mar 27, 2014
wtogami referenced this in commit 036a69c13c on Apr 4, 2014
MathyV referenced this in commit b52f14c8da on May 9, 2014
MathyV referenced this in commit 24ae54e511 on Jul 31, 2014
MathyV referenced this in commit 65fd9e9447 on Jul 31, 2014
MathyV referenced this in commit 6784990468 on Aug 3, 2014
MathyV referenced this in commit defd1f62dd on Aug 5, 2014
luke-jr referenced this in commit 6dcd63eda7 on Dec 18, 2018
Bushstar referenced this in commit 40399fd973 on Apr 8, 2020
Bushstar referenced this in commit c0dda38fea on Apr 8, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

laanwj

Diapolo

Labels

GUI

Linked (view graph)

#3137 RPC: error code changes and prevent crash with walletpassphrase