test: add missing sync to feature_fee_estimation.py #31016

1. 
   mzumsande commented at 10:12 pm on October 1, 2024: contributor

   This fixes a race:

   • In the test_estimate_dat_is_flushed_periodically subtest, node 0 is isolated and creates 10 blocks (no sync).
   • In clear_estimates the nodes are reconnected (but we don’t wait for them to sync!)
   • In the sanity_check_rbf_estimates subtest, node 1 generates another block and syncs with the other nodes. The sync fails if the generated block is at the same height as the tip of node 0.

   Fix this by adding a sync to clear_estimates.

   Fixes #30990 Fixes #30640

2. test: add missing sync to feature_fee_estimation.py

   Fixes a race between node 1 catching up with the chain and mining a
   new block in the sanity_check_rbf_estimates subtest.

   a1576edab3
3. 
   DrahtBot commented at 10:12 pm on October 1, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	tdb3, maflcko
   Concept ACK	ismaelsadeeq

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Oct 1, 2024
5. 
   ismaelsadeeq commented at 10:28 pm on October 1, 2024: member

   Concept ACK

   Thanks for solving the issue

   Should also fix #30640?

6. 
   mzumsande commented at 0:06 am on October 2, 2024: contributor

   Should also fix #30640?

   Yes! I didn’t analyze that in detail but I think that’s very likely. I’ll add it to the OP.

7. tdb3 approved
8. 
   tdb3 commented at 0:21 am on October 2, 2024: contributor

   code review ACK a1576edab356053c4c736691e4950b58e9a14f76
9. DrahtBot requested review from ismaelsadeeq on Oct 2, 2024
10. 
    maflcko commented at 5:55 am on October 2, 2024: member

    lgtm ACK a1576edab356053c4c736691e4950b58e9a14f76
11. fanquake merged this on Oct 2, 2024
12. fanquake closed this on Oct 2, 2024

    ---

13. mzumsande deleted the branch on Oct 2, 2024

Contributors
mzumsande DrahtBot ismaelsadeeq tdb3 maflcko

Review Requested
ismaelsadeeq

Labels
Tests