test: Treat exclude list warning as failure in CI #31018

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2410-test-warn-fail changing 1 files +7 −4
  1. maflcko commented at 1:37 pm on October 2, 2024: member

    An outdated exclude list or otherwise an error in the exclude list handling is usually a bug.

    So make it fatal in the CI, instead of silently ignoring it.

    Fixes https://github.com/bitcoin/bitcoin/pull/30872/files#r1757015334

    Can be tested with something like (with and without --ci):

    0./bld-cmake/test/functional/test_runner.py wallet_disable -x wallet_disablee
    
  2. test: Treat exclude list warning as failure in CI fa6d14eacb
  3. DrahtBot commented at 1:37 pm on October 2, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK tdb3, ismaelsadeeq

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Oct 2, 2024
  5. DrahtBot added the label CI failed on Oct 2, 2024
  6. tdb3 approved
  7. tdb3 commented at 11:42 pm on October 2, 2024: contributor

    ACK fa6d14eacb2a8c1c3243e3075254dfdebaa9290e

    Lightly tested with:

    0$ build/test/functional/test_runner.py --ci rpc_users.py --exclude not_in_list
    1Temporary test directory at /tmp/test_runner_₿_🏃_20241002_194128
    2WARNING! Test 'not_in_list' not found in current test list. Check the --exclude list.
    3$ echo $?
    41
    
  8. ismaelsadeeq commented at 10:43 am on October 3, 2024: member
    utACK fa6d14eacb2a8c1c3243e3075254dfdebaa9290e
  9. DrahtBot removed the label CI failed on Oct 7, 2024
  10. fanquake merged this on Oct 8, 2024
  11. fanquake closed this on Oct 8, 2024

  12. maflcko deleted the branch on Oct 8, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-26 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me