doc: clarify 'filename' argument in 'loadwallet' RPC #31031

pull dollarparity wants to merge 1 commits into bitcoin:master from dollarparity:patch-1 changing 1 files +9 −5
  1. dollarparity commented at 2:49 AM on October 4, 2024: none

    Update the 'loadwallet' RPC help text to specify that the 'filename' should be provided as a path relative to the wallets directory. Add examples showing how to load a wallet from a different directory.

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. doc: clarify 'filename' argument in 'loadwallet' RPC
    Update the 'loadwallet' RPC help text to specify that the 'filename' should be provided as a path relative to the wallets directory. Add examples showing how to load a wallet from a different directory.
    94cc88f0cb
  3. DrahtBot commented at 2:49 AM on October 4, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #30302 (doc: clarify loadwallet path loading for wallets by am-sq)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot added the label Docs on Oct 4, 2024
  5. achow101 commented at 3:11 AM on October 4, 2024: member

    Duplicate of #30302

  6. achow101 marked this as duplicate on Oct 4, 2024
  7. fanquake closed this on Oct 8, 2024

  8. dollarparity deleted the branch on Oct 8, 2024
  9. bitcoin locked this on Oct 8, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me