ci: Add missing -DWERROR=ON to test-each-commit #31045

1. 
   maflcko commented at 10:30 am on October 7, 2024: member

   Found by in Sjors in #27260 (review) (Thanks!)

   Also, includes an unrelated commit to simplify the ci scripts, by assuming nproc exists on macos as well. (Having more than one commit is also required to trigger the test-each-commit task)

2. ci: Add missing -DWERROR=ON to test-each-commit faf7a2bccc
3. ci: Install missing nproc in macos task

   This avoids special-casing macos

   fa1cffacae
4. 
   DrahtBot commented at 10:31 am on October 7, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	theuni

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30997 (build: Switch to Qt 6 by hebasto)
   • #30315 (Stratum v2 Transport by Sjors)
   • #29346 (Stratum v2 Noise Protocol by Sjors)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. DrahtBot renamed this:
   ci: Add missing -DWERROR=ON to test-each-commit
   ci: Add missing -DWERROR=ON to test-each-commit
   on Oct 7, 2024
6. DrahtBot added the label Tests on Oct 7, 2024
7. theuni approved
8. 
   theuni commented at 2:34 pm on October 7, 2024: member

   utACK fa1cffacae61264ac89e30a069ba093495cb3216.

   Nice catch on the Werror.

   A quick search confirms that nproc and hw.logicalcpu should be the same value.

9. 
   maflcko commented at 2:47 pm on October 7, 2024: member

   The CI logs:

   • Before https://github.com/bitcoin/bitcoin/actions/runs/11091169274/job/30814507260#step:6:353:

   0Treat compiler warnings as errors ..... OFF
   

   • Before https://github.com/bitcoin/bitcoin/actions/runs/11091169274/job/30814506890#step:7:175:

   0Number of CPUs: 3
   

   • This pull https://github.com/bitcoin/bitcoin/actions/runs/11213662779/job/31167158663?pr=31045#step:6:350:

   0Treat compiler warnings as errors ..... ON
   

   • This pull https://github.com/bitcoin/bitcoin/actions/runs/11213662779/job/31167158063?pr=31045#step:7:171:

   0Number of available processing units: 3
   

10. 
    Sjors commented at 5:47 pm on October 7, 2024: member

    by assuming nproc exists on macos as well

    It doesn’t, but you can do alias nproc="sysctl -n hw.physicalcpu" instead of installing all of coreutils. Though on CI that’s fine by me too.

    https://gist.github.com/oleg-andreyev/053b90ef33d2c29446ef466a2817d01c

11. 
    maflcko commented at 9:17 am on October 8, 2024: member

    you can do alias nproc="sysctl -n hw.physicalcpu" instead of installing all of coreutils.

    No. It needs to be a real executable in PATH, otherwise, it won’t be picked up in a new shell:

    0$ alias npr=nproc ; type npr ; bash -c 'type npr'
    1npr is aliased to `nproc'
    2bash: line 1: type: npr: not found
    

    If you disagree, I am happy to push any other commit, which passes CI and achieves the same.

12. fanquake merged this on Oct 8, 2024
13. fanquake closed this on Oct 8, 2024

    ---

14. maflcko deleted the branch on Oct 8, 2024
15. 
    Sjors commented at 9:27 am on October 10, 2024: member

    It only impacts CI, so is fine by me.

Contributors
maflcko DrahtBot theuni Sjors

Labels
Tests