lint: commit-script-check.sh: echo to stderr #31063

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2410-lint-echo-stderr changing 1 files +7 −7
  1. maflcko commented at 4:05 pm on October 9, 2024: member

    This makes it easier to redirect the produced git diff on failure. On success, it shouldn’t hurt, because the same output is still present, just on stderr.

    Can be tested by introducing a fault in any scripted diff and then calling commit-script-check.sh HEAD~..HEAD > any_file.txt. Previously the file contained the full output, now it contains just the diff.

  2. lint: commit-script-check.sh: echo to stderr fac6cfe5ac
  3. DrahtBot commented at 4:05 pm on October 9, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK TheCharlatan

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Oct 9, 2024
  5. TheCharlatan approved
  6. TheCharlatan commented at 8:38 pm on October 11, 2024: contributor

    ACK fac6cfe5ac06547c90da6f976d7c8bed20da8bac

    The change is fine, but what are you going to do with this?

  7. maflcko commented at 10:49 am on October 15, 2024: member
    This makes it easier to rebase a scripted-diff. Now, it is trivial to run it and redirect the failing diff and apply it later. Previously it was required to be manually edited before applying.
  8. fanquake merged this on Oct 21, 2024
  9. fanquake closed this on Oct 21, 2024

  10. maflcko deleted the branch on Oct 23, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-26 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me