doc: Add xz-utils to the general dependencies for windows build #31084

pull Av32000 wants to merge 1 commits into bitcoin:master from Av32000:doc-windows-build-fix changing 1 files +1 −1
  1. Av32000 commented at 8:52 pm on October 13, 2024: none

    The xz-utils package is not always installed by default on WSL. So when compiling bitcoin core for windows following the doc the compilation of qt causes a critical error. xz-utils must then be installed afterwards. The bug creates a folder /bitcoin/depends/work/build/x86_64-w64-mingw32/qt which blocks the compilation process. You need to manually delete this folder to continue compiling.

    xz-utils, installed by default, avoids this inconvenience.

  2. doc: Add xz-utils to the general dependencies for windows build 2e7293318d
  3. DrahtBot commented at 8:52 pm on October 13, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. DrahtBot added the label Docs on Oct 13, 2024
  5. Patres7771 approved
  6. Patres7771 commented at 9:09 pm on October 13, 2024: none

  7. pinheadmz commented at 9:27 pm on October 13, 2024: member
  8. Av32000 commented at 10:14 pm on October 13, 2024: none
    Yes but required for qt build
  9. laanwj commented at 12:59 pm on October 14, 2024: member

    To be specific, the depends build for qt (and some of its dependencies) requires extracting xz packages:

    0packages/expat.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
    1packages/freetype.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
    2packages/libxcb.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
    3packages/libxkbcommon.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
    4packages/qt.mk:$(package)_suffix=everywhere-opensource-src-$($(package)_version).tar.xz
    5packages/xcb_proto.mk:$(package)_file_name=xcb-proto-$($(package)_version).tar.xz
    

    Depends-specific dependencies are already listed in depends/README.md so i’m not sure repeating them in the OS-specific build guides makes sense.

    It might because we repeat some of the other depends steps here too..(and its explicitly about cross-compiling). no strong opinion…

  10. in doc/build-windows.md:35 in 2e7293318d
    31@@ -32,7 +32,7 @@ First, install the general dependencies:
    32 
    33     sudo apt update
    34     sudo apt upgrade
    35-    sudo apt install cmake curl g++ git make pkg-config
    36+    sudo apt install cmake curl g++ git make pkg-config xz-utils
    


    maflcko commented at 2:34 pm on October 14, 2024:
    It is also missing bison and patch? Might as well remove it and just refer to the location that is correct?

    laanwj commented at 2:39 pm on October 14, 2024:
    +1, although it’s somewhat less convienient, refering to the depends README for what to install would be easier to maintain cleanly. Otherwise, if it changes, people have to think of updating this too.

    Av32000 commented at 7:28 pm on October 14, 2024:
    I agree with you, I’m closing the pr.
  11. Av32000 closed this on Oct 14, 2024

  12. Av32000 deleted the branch on Oct 14, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-26 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me