The xz-utils package is not always installed by default on WSL. So when compiling bitcoin core for windows following the doc the compilation of qt causes a critical error. xz-utils must then be installed afterwards. The bug creates a folder /bitcoin/depends/work/build/x86_64-w64-mingw32/qt which blocks the compilation process. You need to manually delete this folder to continue compiling.
xz-utils, installed by default, avoids this inconvenience.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process. A summary of reviews will appear here.
Yes but required for qt build
To be specific, the depends build for qt (and some of its dependencies) requires extracting xz packages:
packages/expat.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
packages/freetype.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
packages/libxcb.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
packages/libxkbcommon.mk:$(package)_file_name=$(package)-$($(package)_version).tar.xz
packages/qt.mk:$(package)_suffix=everywhere-opensource-src-$($(package)_version).tar.xz
packages/xcb_proto.mk:$(package)_file_name=xcb-proto-$($(package)_version).tar.xz
Depends-specific dependencies are already listed in depends/README.md so i'm not sure repeating them in the OS-specific build guides makes sense.
It might because we repeat some of the other depends steps here too..(and its explicitly about cross-compiling). no strong opinion...
31 | @@ -32,7 +32,7 @@ First, install the general dependencies: 32 | 33 | sudo apt update 34 | sudo apt upgrade 35 | - sudo apt install cmake curl g++ git make pkg-config 36 | + sudo apt install cmake curl g++ git make pkg-config xz-utils
It is also missing bison and patch? Might as well remove it and just refer to the location that is correct?
+1, although it's somewhat less convienient, refering to the depends README for what to install would be easier to maintain cleanly. Otherwise, if it changes, people have to think of updating this too.
I agree with you, I'm closing the pr.