ci: display logs of failed unit tests automatically #31148

1. 
   furszy commented at 1:57 pm on October 24, 2024: member

   Saw it here https://github.com/bitcoin/bitcoin/actions/runs/11488618084/job/31975712362?pr=31000.

   The ’test-each-commit’ and ‘win64’ CI jobs currently do not display test logs when an error occurs, making it almost impossible to debug issues that don’t arise locally. Fix this by setting the CTest --output-on-failure flag (per README).

2. ci: display logs of failed tests automatically 8523d8c0fc
3. 
   DrahtBot commented at 1:57 pm on October 24, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Oct 24, 2024
5. 
   maflcko commented at 2:45 pm on October 24, 2024: member

   Lgtm. Nice find.

   I wish this was enabled by default. There should never be a case to be shy when an error occurs and autotools didn’t do that either.

6. hebasto approved
7. 
   hebasto commented at 3:11 pm on October 24, 2024: member

   ACK 8523d8c0fc85c5511311628d47c78fa380b99f6e, I have reviewed the code and it looks OK.
8. 
   maflcko commented at 3:29 pm on October 24, 2024: member

   CI failure is (obviously) unrelated and can be ignored: https://github.com/bitcoin/bitcoin/issues/31151
9. fanquake merged this on Oct 24, 2024
10. fanquake closed this on Oct 24, 2024

    ---

11. furszy deleted the branch on Oct 24, 2024

Contributors
furszy DrahtBot maflcko hebasto

Labels
Tests