ci: Do not error on unused-member-function in test each commit #31187

1. 
   sr-gi commented at 6:01 pm on October 30, 2024: member

   After #31045, an unused method in a commit will trigger a compilation error, even if that method is later used in a following commit within the same PR.

   Do not enforce unused-member-function in test each commit.

   Close #31180

2. ci: Do not error on unused-member-function in test each commit 54d07dd37d
3. 
   DrahtBot commented at 6:01 pm on October 30, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31187.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	TheCharlatan, kevkevinpal, maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28710 (Remove the legacy wallet and BDB dependency by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Tests on Oct 30, 2024
5. TheCharlatan approved
6. 
   TheCharlatan commented at 7:46 pm on October 30, 2024: contributor

   lgtm ACK 54d07dd37d5919c4e3bc535ae498d623282741d1
7. 
   maflcko commented at 10:18 am on October 31, 2024: member

   Can you add a dummy commit to trigger the CI, so that the flag difference can be seen, and to confirm that there are no unwanted interactions?
8. 
   kevkevinpal commented at 11:59 am on November 1, 2024: contributor

   lgtm ACK 54d07dd
9. 
   sr-gi commented at 2:18 pm on November 1, 2024: member

   Can you add a dummy commit to trigger the CI, so that the flag difference can be seen, and to confirm that there are no unwanted interactions?

   Done, will drop + force-push once CI runs

10. 
    maflcko commented at 3:02 pm on November 1, 2024: member

    This pull: https://github.com/bitcoin/bitcoin/actions/runs/11630801646/job/32390526596?pr=31187#step:6:337

    0C++ compiler flags .................... -Wno-error=unused-member-function -O2 -g -std=c++20 -fPIC -fdebug-prefix-map=/home/runner/work/bitcoin/bitcoin=. -fmacro-prefix-map=/home/runner/work/bitcoin/bitcoin=. -Werror -Wall -Wextra -Wgnu -Wformat -Wformat-security -Wvla -Wshadow-field -Wthread-safety -Wloop-analysis -Wredundant-decls -Wunused-member-function -Wdate-time -Wconditional-uninitialized -Woverloaded-virtual -Wsuggest-override -Wimplicit-fallthrough -Wunreachable-code -Wdocumentation -Wself-assign -Wundef -Wno-unused-parameter -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -Wstack-protector -fstack-protector-all -fcf-protection=full -fstack-clash-protection
    1Linker flags .......................... -Wno-error=unused-member-function -O2 -g -fstack-protector-all -fcf-protection=full -fstack-clash-protection -Wl,-z,relro -Wl,-z,now -Wl,-z,separate-code -fPIE -pie
    

    Before: https://github.com/bitcoin/bitcoin/actions/runs/11617421996/job/32352606964?pr=31197#step:6:337

    0C++ compiler flags .................... -O2 -g -std=c++20 -fPIC -fdebug-prefix-map=/home/runner/work/bitcoin/bitcoin=. -fmacro-prefix-map=/home/runner/work/bitcoin/bitcoin=. -Werror -Wall -Wextra -Wgnu -Wformat -Wformat-security -Wvla -Wshadow-field -Wthread-safety -Wloop-analysis -Wredundant-decls -Wunused-member-function -Wdate-time -Wconditional-uninitialized -Woverloaded-virtual -Wsuggest-override -Wimplicit-fallthrough -Wunreachable-code -Wdocumentation -Wself-assign -Wundef -Wno-unused-parameter -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -Wstack-protector -fstack-protector-all -fcf-protection=full -fstack-clash-protection
    1Linker flags .......................... -O2 -g -fstack-protector-all -fcf-protection=full -fstack-clash-protection -Wl,-z,relro -Wl,-z,now -Wl,-z,separate-code -fPIE -pie
    

11. 
    maflcko commented at 3:02 pm on November 1, 2024: member

    lgtm ACK 54d07dd37d5919c4e3bc535ae498d623282741d1
12. sr-gi force-pushed on Nov 1, 2024
13. 
    sr-gi commented at 3:34 pm on November 1, 2024: member

    Removed dummy commit
14. fanquake merged this on Nov 1, 2024
15. fanquake closed this on Nov 1, 2024

    ---

Contributors
sr-gi DrahtBot TheCharlatan maflcko kevkevinpal

Labels
Tests