Porting MinGW multithreading bugfix to makefile.mingw #3121

pull phelixbtc wants to merge 1 commits into bitcoin:0.8.5 from phelixbtc:MinGW_MT_fix_port changing 1 files +2 −2

phelixbtc commented at 6:40 PM on October 21, 2013: none

Original fix: https://github.com/bitcoin/bitcoin/commit/8864019f6d88b13d3442843d9e6ebeb8dd938831

Porting MinGW multithreading bugfix to makefile.mingw

Original fix:
https://github.com/bitcoin/bitcoin/commit
/8864019f6d88b13d3442843d9e6ebeb8dd938831

d2078c6319

BitcoinPullTester commented at 6:50 PM on October 21, 2013: none

Automatic sanity-testing: FAILED MERGE, see http://jenkins.bluematt.me/pull-tester/d2078c63193c6105e60e56c1e7a7adc3aed31edd for test log.

This pull does not merge cleanly onto current master This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 10:15 PM on October 21, 2013: member

The makefile buildsystem has since been replaced by autotools in git master. Does autotools do this right, or do we need an equivalent fix there?
Diapolo commented at 7:26 AM on October 22, 2013: none

@theuni Can you take a look?
laanwj commented at 12:36 PM on October 22, 2013: member

I suppose this is useful for @luke-jr for his stable branch.

As for the autotools build system this change is not needed. mingwthrd is detected and -D_MT is added: https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L194
theuni commented at 10:32 PM on October 22, 2013: member

yes, autotools should be handling this correctly already.
theuni commented at 10:34 PM on October 22, 2013: member

Note that I could not find any testers for native win32+autotools. @phelixbtc If you'd be willing to be a guinea pig, I'm happy to get it working there.
phelixbtc commented at 6:46 AM on October 23, 2013: none

I'll try my very best. Should I start out with current master?
theuni commented at 7:32 PM on October 24, 2013: member

Yes. Are you available to hop on freenode for a realtime hack-a-thon?
phelixbtc commented at 9:16 PM on October 27, 2013: none

@theuni: tried to email you... contact me at blockchained.com

I assume this will not go into 0.8.5 then...
luke-jr commented at 9:19 PM on October 27, 2013: member

0.8.5 is already released weeks ago. It'll probably be in 0.8.6, but that may be after 0.9.0
gavinandresen commented at 2:15 AM on November 1, 2013: contributor

Closing; makefile.mingw is no more.
gavinandresen closed this on Nov 1, 2013
Bushstar referenced this in commit a8fa5cff9c on Apr 8, 2020
Bushstar referenced this in commit f2d401aa85 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels