doc: Add missing 'blank=true' option in offline-signing-tutorial.md #31236

pull secp512k2 wants to merge 1 commits into bitcoin:master from secp512k2:patch-2 changing 1 files +1 −0
  1. secp512k2 commented at 6:10 PM on November 6, 2024: contributor

    Issue:

    The text mentions that the createwallet command should use the options disable_private_keys=true, blank=true, but the provided command only includes disable_private_keys=true, missing the blank=true option.


    Details:

    Original Text:

    This is achieved by using the createwallet options: disable_private_keys=true, blank=true.

    Original Command:

    [online]$ ./build/src/bitcoin-cli -signet -named createwallet \
                  wallet_name="watch_only_wallet" \
                  disable_private_keys=true
    

    Correction:

    Added blank=true to the command to match the options described in the text.

    Revised Command:

    [online]$ ./build/src/bitcoin-cli -signet -named createwallet \
                  wallet_name="watch_only_wallet" \
                  disable_private_keys=true \
                  blank=true
    

    Explanation:

    The blank=true option is necessary to create a blank wallet. Including this option ensures the command matches the options specified in the text.

  2. doc: Add missing 'blank=true' option in offline-signing-tutorial.md
    **Issue:**
    
    The text mentions that the `createwallet` command should use the options `disable_private_keys=true, blank=true`, but the provided command only includes `disable_private_keys=true`, missing the `blank=true` option.
    
    **Original Text:**
    
    > This is achieved by using the `createwallet` options: `disable_private_keys=true, blank=true`.
    
    **Original Command:**
    
    ```sh
    [online]$ ./build/src/bitcoin-cli -signet -named createwallet \
                  wallet_name="watch_only_wallet" \
                  disable_private_keys=true
    71945f2a50
  3. DrahtBot commented at 6:10 PM on November 6, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31236.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. DrahtBot added the label Docs on Nov 6, 2024
  5. maflcko commented at 6:15 PM on November 6, 2024: member

    Please don't include the full diff in the pull request description. If someone wanted to look at the diff, they could just do so directly. Also, the diff in the pull description is different from the actual diff, which is broken (invalid syntax).

  6. secp512k2 closed this on Nov 6, 2024

  7. secp512k2 deleted the branch on Nov 6, 2024
  8. bitcoin locked this on Nov 8, 2024
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me