only style-fixes (spaces, new-lines and indentation) #3124

No description provided.

Warning: I'm extra grumpy today for no good reason.

I still hate these types of pulls, they just create merge conflicts for no good reason in my opinion. It is fine to cleanup code as it is rewritten...

@gavinandresen I'm fine with you beeing grumpy, if you are fine with me beeing grumpy on devs that don't care about cleaning up left-over spaces and such (not specific to anyone, just to be sure ^^).

I've never really understood the whitespace shuffling all over the codebase either.

Though "cute" space-aligned tables like in getinfo() invite this kind of behavior. Hey, one of the keys it too long, let's shift all the others!

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/56e527e3052013630d4de33b10bbbb2bf613b937 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

On the other side, most of use likes when the code is clean and well structured. It protects the general quality of the code. It's like entering a very clean house. You will automatically take more care about stuff in it.

Maybe someone take a closer look at cURL's build process. There is a check for empty lines and uncommon source formatting during the make process. In our case PullTester would blame you if you would add some uncommon code structure.

https://github.com/bagder/curl

But i agree. No empty-line-syntax-changes during unfinished developments.

I prefer people to focus foremost on clean semantics, interfaces and data structures.

Sure, the formatting should not be a mess, but we shouldn't be extremists about it. I certainly don't want a commit hook or pulltester that looks at formatting. It's better to be accommodating of people's slightly different tastes with respect to code formatting (try to ignore it and see the meaning beneath it) than be a jerk about it. It just distracts from what we're trying to do.

Obviously too controversial again...