Qt: move paymentACK handling to paymentserver #3130

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:paymentACK_via_message changing 5 files +23 −18

Diapolo commented at 7:32 PM on October 22, 2013: none
- add new slot handlePaymentACK() to paymentserver, which handles paymentACK messages (currently we just display them)
- make paymentACK message a modal information dialog
- change some QObject::tr() to just tr()
- clarify the processPaymentRequest() error, when IsDust()
- small string change to prevent a tripple + usage with QString
laanwj commented at 6:54 AM on October 23, 2013: member

Haven't looked at it in detail yet, but moving the message to PaymentServer makes sense as it only re-emits a message.
laanwj commented at 7:24 AM on October 24, 2013: member

I don't think we should make the paymentack message a tray message. As we are not storing it anywhere for later reference at the moment (or are we?), it's good to give the user some time to read it or even copy it.
Diapolo commented at 7:40 AM on October 24, 2013: none

@laanwj That's fine with me... perhaps there are better methods for handling this message, but that's out of the score of this pr.
Diapolo commented at 7:46 AM on October 24, 2013: none
Updated:
- make paymentACK message a modal information dialog

Qt: move paymentACK handling to paymentserver

- add new slot handlePaymentACK() to paymentserver, which handles
  paymentACK messages (currently we just display them)
- make paymentACK message a modal information dialog
- change some QObject::tr() to just tr()
- clarify the processPaymentRequest() error, when IsDust()
- small string change to prevent a tripple + usage with QString

08dd1b7be1

in src/qt/paymentserver.cpp:None in 07e610d98b outdated

 612 |              qDebug() << "PaymentServer::netRequestFinished : " << msg;
 613 |              emit message(tr("Network request error"), msg, CClientUIInterface::MSG_ERROR);
 614 |          }
 615 |          else {
 616 | -            emit receivedPaymentACK(QString::fromStdString(paymentACK.memo()));
 617 | +            emit message(tr("Payment acknowledged"), GUIUtil::HtmlEscape(paymentACK.memo()), CClientUIInterface::ICON_INFORMATION | CClientUIInterface::MODAL);

laanwj commented at 12:33 PM on October 24, 2013:

Hm I'd suggest to keep the signal, and subscribe to it locally; what if we want to do something else with the ACK later on?

Diapolo commented at 1:16 PM on October 24, 2013:

I'm going to change that :).

Diapolo commented at 1:46 PM on October 24, 2013: none
Updated to reflect @laanwj's suggestion:
- add new slot handlePaymentACK() to paymentserver, which handles paymentACK messages (currently we just display them)
laanwj commented at 1:51 PM on October 24, 2013: member

ACK
BitcoinPullTester commented at 2:13 PM on October 24, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/08dd1b7be172f7ea580dc9bdf20ac15ea9a2ed31 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 48cc4fc326 on Oct 25, 2013
laanwj merged this on Oct 25, 2013
laanwj closed this on Oct 25, 2013
Bushstar referenced this in commit d49ee618f9 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester