This PR switches to the latest IWYU 0.23, which is compatible with Clang 19.
The “bugprone-use-after-move” and “modernize-use-starts-ends-with” warnings that emerged have been resolved.
Enabling the “performance-inefficient-vector-operation” and “performance-unnecessary-copy-initialization” checks is deferred to follow-up PRs (e.g., #31305).
This change switches to the latest IWYU 0.23, which is compatible with
Clang 19.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31306.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| Concept NACK | l0rinc |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
See: https://github.com/include-what-you-use/include-what-you-use/pull/1560
18@@ -19,8 +19,10 @@ performance-*,
19 -performance-avoid-endl,
20 -performance-enum-size,
21 -performance-inefficient-string-concatenation,
22+-performance-inefficient-vector-operation,
Right.
It depends on which PR is merged first :)
5@@ -6,9 +6,9 @@
6
7 export LC_ALL=C.UTF-8
8
9-export CI_IMAGE_NAME_TAG="docker.io/ubuntu:24.04"
10+export CI_IMAGE_NAME_TAG="docker.io/ubuntu:24.10"
Not sure about using releases which are basically EOL in less than 6 months after the release branch is created. This requires touching the release branches to bump those along.
My preference would be to use APT_LLVM_V
63+void ExpectSuccess(const util::Result<T>& result, const bilingual_str& str, const Args&... args)
64 {
65 ExpectResult(result, true, str);
66 BOOST_CHECK_EQUAL(result.has_value(), true);
67- BOOST_CHECK_EQUAL(result.value(), T{std::forward<Args>(args)...});
68+ BOOST_CHECK_EQUAL(result.value(), T{args...});
ExpectSuccess(StrFn(Untranslated("S"), true), {}, Untranslated("S"));?
770@@ -771,11 +771,10 @@ static void CheckAddCoinBase(CAmount base_value, CAmount cache_value, CAmount mo
771 // while still verifying that the CoinsViewCache::AddCoin implementation
772 // ignores base values.
773 template <typename... Args>
774-static void CheckAddCoin(Args&&... args)
58@@ -59,12 +59,11 @@ void ExpectResult(const util::Result<T>& result, bool success, const bilingual_s
59 }
60
61 template <typename T, typename... Args>
62-void ExpectSuccess(const util::Result<T>& result, const bilingual_str& str, Args&&... args)
63+void ExpectSuccess(const util::Result<T>& result, const bilingual_str& str, const Args&... args)
Looking at the actual usage, ExpectSuccess doesn’t need to be a variadic template function:
0ExpectSuccess(IntFn(5, true), {}, 5);
1ExpectSuccess(NoCopyFn(5, true), {}, 5);
2ExpectSuccess(StrFn(Untranslated("S"), true), {}, Untranslated("S"));
, we might as well simplify to something like:
0template <typename T, typename U>
1void ExpectSuccess(const util::Result<T>& result, const bilingual_str& str, U&& expected)
2{
3 ExpectResult(result, true, str);
4 BOOST_CHECK_EQUAL(result.has_value(), true);
5 BOOST_CHECK_EQUAL(result.value(), expected);
6 BOOST_CHECK_EQUAL(&result.value(), &*result);
7}