Simplify constructor in fuzz test to help msvc compiler frontend parser. #31311
pull sipsorcery wants to merge 1 commits into bitcoin:master from sipsorcery:fix-fuzz-msvc changing 1 files +6 −8-
sipsorcery commented at 9:00 am on November 18, 2024: contributorResolves #31303.
-
Simplify constructor in fuzz test to help msvc compiler frontend parser. 125901ef52
-
DrahtBot commented at 9:00 am on November 18, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31311.
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
-
in src/test/fuzz/utxo_snapshot.cpp:49 in 125901ef52
52- .setup_net = false, 53- .setup_validation_interface = false, 54- .min_validation_cache = true, 55- }), 56- }; 57+ const auto setup = MakeNoLogFileContext<TestingSetup>(ChainType::REGTEST,
maflcko commented at 9:04 am on November 18, 2024:It is easy to see that this code was generated by an LLM (https://github.com/bitcoin/bitcoin/issues/31303#issuecomment-2481584659), because it is wrong.
Luckily CI should catch this error.
sipsorcery commented at 9:11 am on November 18, 2024:Whoops, I did inspect but yes, missed the static keyword getting dropped. Guess it will need to wait for an msvc fix then.sipsorcery closed this on Nov 18, 2024
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 18:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 18:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me