Simplify constructor in fuzz test to help msvc compiler frontend parser. #31311

pull sipsorcery wants to merge 1 commits into bitcoin:master from sipsorcery:fix-fuzz-msvc changing 1 files +6 −8

sipsorcery commented at 9:00 AM on November 18, 2024: contributor

Resolves #31303.
Simplify constructor in fuzz test to help msvc compiler frontend parser. 125901ef52
DrahtBot commented at 9:00 AM on November 18, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31311.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
in src/test/fuzz/utxo_snapshot.cpp:49 in 125901ef52
```
  52 | -                                               .setup_net = false,
  53 | -                                               .setup_validation_interface = false,
  54 | -                                               .min_validation_cache = true,
  55 | -                                           }),
  56 | -    };
  57 | +    const auto setup = MakeNoLogFileContext<TestingSetup>(ChainType::REGTEST,
```
maflcko commented at 9:04 AM on November 18, 2024:

It is easy to see that this code was generated by an LLM (https://github.com/bitcoin/bitcoin/issues/31303#issuecomment-2481584659), because it is wrong.

Luckily CI should catch this error.

sipsorcery commented at 9:11 AM on November 18, 2024:

Whoops, I did inspect but yes, missed the static keyword getting dropped. Guess it will need to wait for an msvc fix then.
sipsorcery closed this on Nov 18, 2024
bitcoin locked this on Nov 18, 2025

Contributors

sipsorcery

DrahtBot

maflcko

Linked (view graph)

#31303 MSVC 17.12.0 internal compiler error

Simplify constructor in fuzz test to help msvc compiler frontend parser. #31311

Code Coverage & Benchmarks

Reviews