I removed else block. Also, I fixed 'return false' in the PUBKEY case. It helps the logic and improves readability.
Update addresstype.cpp #31354
pull karurung wants to merge 1 commits into bitcoin:master from karurung:patch-1 changing 1 files +3 −3-
karurung commented at 5:09 AM on November 23, 2024: none
-
22e62b468b
Update addresstype.cpp
I removed `else` block. Also, I fixed 'return false' in the PUBKEY case. It helps the logic and improves readability.
-
DrahtBot commented at 5:09 AM on November 23, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31354.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
l0rinc commented at 9:38 AM on November 23, 2024: contributor
NACK, no high-level motivation given, code is worse than before (unformatted)
-
brunoerg commented at 1:53 PM on November 23, 2024: contributor
NACK
- maflcko closed this on Nov 24, 2024
- karurung deleted the branch on Nov 24, 2024
- bitcoin locked this on Nov 24, 2025
