Update addresstype.cpp #31354

pull karurung wants to merge 1 commits into bitcoin:master from karurung:patch-1 changing 1 files +3 −3
  1. karurung commented at 5:09 am on November 23, 2024: none
    I removed else block. Also, I fixed ‘return false’ in the PUBKEY case. It helps the logic and improves readability.
  2. Update addresstype.cpp
    I removed `else` block. Also, I fixed 'return false' in the PUBKEY case.
    It helps the logic and improves readability.
    22e62b468b
  3. DrahtBot commented at 5:09 am on November 23, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31354.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept NACK l0rinc, brunoerg

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. l0rinc commented at 9:38 am on November 23, 2024: contributor
    NACK, no high-level motivation given, code is worse than before (unformatted)
  5. brunoerg commented at 1:53 pm on November 23, 2024: contributor
    NACK
  6. maflcko closed this on Nov 24, 2024

  7. karurung deleted the branch on Nov 24, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-26 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me