qa: Broken wallet_multiwallet.py #31409

1. 
   hebasto commented at 11:47 am on December 3, 2024: member

   On the master branch @ ebe4cac38bf6c510b00b8e080acab079c54016d6, the wallet_multiwallet.py test has several issues:

   1. This code: https://github.com/bitcoin/bitcoin/blob/ebe4cac38bf6c510b00b8e080acab079c54016d6/test/functional/wallet_multiwallet.py#L132-L140 checks for the “Error scanning” message in the debug.log caused by processing the no_access directory. However, the same message can also be generated when parsing the self_walletdat_symlink directory. As a result, the current implementation is prone to producing false-positive results.

   2. Parsing the self_walletdat_symlink directory with bitcoind.exe depends on how it was built. When cross-compiling, the parsing completes without system errors. On the other hand, when building natively, it raises an “unknown error” exception and logs the “Error scanning” message.

   3. This code: https://github.com/bitcoin/bitcoin/blob/ebe4cac38bf6c510b00b8e080acab079c54016d6/test/functional/wallet_multiwallet.py#L132-L139 is not portable due to its use of os.chmod:

   Note: Although Windows supports chmod(), you can only set the file’s read-only flag with it (via the stat.S_IWRITE and stat.S_IREAD constants or a corresponding integer value).

2. hebasto added the label Tests on Dec 3, 2024
3. 
   maflcko commented at 12:45 pm on December 3, 2024: member

   I guess it would be good to separate the no_access and symlink unit tests into two test cases, not combine them into one. This would allow to skip just one of them, if needed on Windows.

Contributors
hebasto maflcko

Labels
Tests