test: orphan parent is re-requested from 2nd peer #31414

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:2024-12-double-request-orphan-parent changing 1 files +5 −1
  1. instagibbs commented at 4:19 pm on December 3, 2024: member
    Small test which I couldn’t find coverage for.
  2. func: test orphan parent is re-requested from 2nd peer 0f84cdd266
  3. DrahtBot renamed this:
    func: test orphan parent is re-requested from 2nd peer
    test: orphan parent is re-requested from 2nd peer
    on Dec 4, 2024
  4. DrahtBot added the label Tests on Dec 4, 2024
  5. glozow commented at 12:35 pm on December 4, 2024: member
    lgtm ACK 0f84cdd26614a229d9aee6cd74a1aa01b204a1f5
  6. DrahtBot commented at 12:35 pm on December 4, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31414.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK glozow, tdb3, theStack, marcofleon

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  7. tdb3 approved
  8. tdb3 commented at 5:20 pm on December 4, 2024: contributor

    code review ACK 0f84cdd26614a229d9aee6cd74a1aa01b204a1f5

    Looks good.

  9. theStack approved
  10. theStack commented at 10:39 pm on December 4, 2024: contributor
    ACK 0f84cdd26614a229d9aee6cd74a1aa01b204a1f5
  11. marcofleon commented at 11:29 am on December 5, 2024: contributor
    tACK 0f84cdd26614a229d9aee6cd74a1aa01b204a1f5. Removing node.bumpmocktime(GETDATA_TX_INTERVAL) results in failure.
  12. glozow merged this on Dec 5, 2024
  13. glozow closed this on Dec 5, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-01-21 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me