test: orphan parent is re-requested from 2nd peer #31414
pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:2024-12-double-request-orphan-parent changing 1 files +5 −1-
instagibbs commented at 4:19 pm on December 3, 2024: memberSmall test which I couldn’t find coverage for.
-
func: test orphan parent is re-requested from 2nd peer 0f84cdd266
-
DrahtBot renamed this:
func: test orphan parent is re-requested from 2nd peer
test: orphan parent is re-requested from 2nd peer
on Dec 4, 2024 -
DrahtBot added the label Tests on Dec 4, 2024
-
glozow commented at 12:35 pm on December 4, 2024: memberlgtm ACK 0f84cdd26614a229d9aee6cd74a1aa01b204a1f5
-
DrahtBot commented at 12:35 pm on December 4, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31414.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK glozow, tdb3, theStack, marcofleon If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
tdb3 approved
-
tdb3 commented at 5:20 pm on December 4, 2024: contributor
code review ACK 0f84cdd26614a229d9aee6cd74a1aa01b204a1f5
Looks good.
-
theStack approved
-
theStack commented at 10:39 pm on December 4, 2024: contributorACK 0f84cdd26614a229d9aee6cd74a1aa01b204a1f5
-
marcofleon commented at 11:29 am on December 5, 2024: contributortACK 0f84cdd26614a229d9aee6cd74a1aa01b204a1f5. Removing
node.bumpmocktime(GETDATA_TX_INTERVAL)
results in failure. -
glozow merged this on Dec 5, 2024
-
glozow closed this on Dec 5, 2024
instagibbs
glozow
DrahtBot
tdb3
theStack
marcofleon
Labels
Tests
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-01-21 06:12 UTC
More mirrored repositories can be found on mirror.b10c.me