Autoconf improvements, part 2 #3147

No description provided.

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/fa94a2ee7a3610c285ba57e02938aa05172cf5dd for binaries and test log.

This could happen for one of several reasons:

1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
4. The test suite fails on either Linux i386 or Win32
5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

Looks pretty good, based on a 60-second, untested review ;p

Agree with the first two commits; --with-system-leveldb is a bit controversial, as it may nudge distro packagers the wrong way. There's a good reason that we include our own copy of leveldb.

I have to agree that --with-system-leveldb sends the wrong message to distributions.

Perhaps an AC_WARN would be appropriate.

@luke-jr you know just as well as us that they'll just ignore that