depends: Ignore prefix directory on OpenBSD #31498

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:241214-ignore-amd changing 1 files +1 −0
  1. hebasto commented at 10:00 am on December 14, 2024: member

    On OpenBSD, the prefix directory is named as follows:

    0$ gmake --no-print-directory -C depends print-x86_64_openbsd_prefix
    1x86_64_openbsd_prefix=/home/hebasto/dev/bitcoin/depends/amd64-unknown-openbsd7.6
    

    This name does not match any pattern in depends/.gitignore.

    This PR resolves this issue.

  2. depends: Ignore prefix directory on OpenBSD 3353d4a5e9
  3. DrahtBot commented at 10:00 am on December 14, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31498.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK tdb3, theuni, theStack

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Build system on Dec 14, 2024
  5. tdb3 approved
  6. tdb3 commented at 2:01 am on December 15, 2024: contributor

    ACK 3353d4a5e9fc8887b2ebe54d49ec0675147d9d47

    In openbsd 7.5, saw git status show depends/arm64-unknown-openbsd7.5 as an untracked file(dir) on master, but not on the PR branch.

    Also took a look at the host-platform-triplets in https://github.com/bitcoin/bitcoin/blob/master/depends/README.md to see if there were others that the .gitignore might me missing. Didn’t see any.

  7. theuni approved
  8. theuni commented at 5:25 pm on December 16, 2024: member

    utACK 3353d4a5e9fc8887b2ebe54d49ec0675147d9d47

    I don’t have an openbsd install to test this, but I believe you :)

  9. theStack approved
  10. theStack commented at 2:20 am on December 17, 2024: contributor

    Tested ACK 3353d4a5e9fc8887b2ebe54d49ec0675147d9d47 🐟

    (verified on OpenBSD 7.5)

  11. fanquake merged this on Dec 17, 2024
  12. fanquake closed this on Dec 17, 2024

  13. hebasto deleted the branch on Dec 17, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-21 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me