bitcoin_consensus as a library
#31503
The TARGET_OBJECTS generator expression was introduced in the staging branch when we aimed to build the libbitcoinconsensus shared library. However, bitcoin_consensus is a STATIC library, not an OBJECT library.
This change updates the build system to link bitcoin_consensus normally to test_bitcoin, resolving linking issues when building with clang-cl.
The TARGET_OBJECTS generator expression was introduced in the staging
branch when we aimed to build the libbitcoinconsensus shared library.
However, `bitcoin_consensus` is a STATIC library, not an OBJECT library.
This change updates the build system to link `bitcoin_consensus`
normally to `test_bitcoin`, resolving linking issues when building with
clang-cl.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31503.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | TheCharlatan, theuni |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
{test,bench}_bitcoin targets by hebasto)If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
