qt: clean up signal handling in walletframe/walletview #3151

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_10_walletview changing 4 files +37 −43

laanwj commented at 2:17 PM on October 25, 2013: member

@diapolo this continues the work in #3144, does this look sane?

Use proper signals everywhere. Removes the need to store a pointer to the BitcoinGUI object in the walletview. Also removes the interdependence between setWalletModel / setBitcoinGUI.

Warning: not everything is tested yet
BitcoinPullTester commented at 2:37 PM on October 25, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/acf05c01ffb664047d51ef635b4bffe215045bce for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 6:05 PM on October 25, 2013: none

Looks sane, can't test today.... we are on a good way cleaning up that kind of stuff :-).

qt: clean up signal handling in walletframe/walletview

Use proper signals everywhere.
Removes the need to store a pointer to the BitcoinGUI object in
the walletview.
Also removes the interdependence between setWalletModel / setBitcoinGUI.

7d16bb3874

laanwj referenced this in commit ff7a834f6b on Oct 27, 2013
laanwj merged this on Oct 27, 2013
laanwj closed this on Oct 27, 2013
laanwj deleted the branch on Apr 9, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

laanwj

BitcoinPullTester

Diapolo

Linked (view graph)

#3144 allow emit message() in sendcoinsdialog and walletview