cmake: Remove unused BUILD_TESTING variable from “dev-mode” preset #31544

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:241219-unused changing 1 files +0 −1
  1. hebasto commented at 10:29 pm on December 19, 2024: member

    On the master branch @ bb57017b2945d5e0bbd95c7f1a9369a8ab7c6fcd:

     0$ cmake -B build --preset dev-mode -DWITH_MULTIPROCESS=OFF
     1<snip>
     2-- Configuring done (12.0s)
     3-- Generating done (0.1s)
     4CMake Warning:
     5  Manually-specified variables were not used by the project:
     6
     7    BUILD_TESTING
     8
     9
    10-- Build files have been written to: /home/hebasto/git/bitcoin/build
    

    This PR resolves the issue.

    The removed BUILD_TESTING variable is a part of the CTest module, which we do not include in the project.

  2. cmake: Remove unused `BUILD_TESTING` variable from "dev-mode" preset e196190a28
  3. hebasto added the label Build system on Dec 19, 2024
  4. DrahtBot commented at 10:29 pm on December 19, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31544.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK TheCharlatan

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. sedited approved
  6. sedited commented at 10:36 am on December 20, 2024: contributor
    ACK e196190a284fc6ffd21a39cfae957fdd8b4657b6
  7. fanquake merged this on Dec 20, 2024
  8. fanquake closed this on Dec 20, 2024

  9. hebasto deleted the branch on Dec 20, 2024
  10. sedited referenced this in commit 230a439a4a on Jan 17, 2025
  11. stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
  12. stickies-v referenced this in commit cc83553352 on Mar 17, 2025
  13. stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
  14. stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
  15. stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
  16. bug-castercv502 referenced this in commit 44b075fe71 on Sep 28, 2025
  17. bitcoin locked this on Dec 20, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-31 03:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me