build: Use character literals for generated headers to avoid narrowing #31547

pull l0rinc wants to merge 1 commits into bitcoin:master from l0rinc:l0rinc/GenerateHeaderFromJson-character-literal changing 2 files +2 −2
  1. l0rinc commented at 1:39 pm on December 20, 2024: contributor

    Use character literals instead of integer hex values (i.e. '\x5b','\x0a', ... instead of 0x5b, 0x0a, ...) for generated JSON headers for tests. This avoids C++11 narrowing warnings in a more concise way than using explicit char casts.

    Extra whitespace is also removed between elements for brevity.

    Split out of #31542 (review)

  2. build: Use character literals for generated headers to avoid narrowing
    Use character literals instead of integer hex values (i.e. `'\x5b','\x0a', ...` instead of `0x5b, 0x0a, ...`) for generated headers.
    This avoids C++11 narrowing warnings in a more concise way than using explicit char casts.
    
    Extra whitespace is also removed between elements for brevity.
    63b6b638aa
  3. DrahtBot commented at 1:39 pm on December 20, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31547.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #31176 (ci: Test cross-built Windows executables on Windows natively by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot added the label Build system on Dec 20, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-21 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me