Split MIN_PROTO_VERSION into INIT_PROTO_VERSION and MIN_PEER_PROTO_VERSION #3155

pull wtogami wants to merge 1 commits into bitcoin:master from wtogami:split_proto_var changing 3 files +9 −7

wtogami commented at 9:49 AM on October 26, 2013: contributor

INIT_PROTO_VERSION is the initial version, after a succesful version/verack it is increased to a negotiated version. MIN_PEER_PROTO_VERSION could be a different value to disconnect from peers older than a specified version.

This commit alone does not change any behavior. It stresses the difference between the initial and minimum version, the latter of which can be set to enforce a minimum version in a later policy discussion.

Split MIN_PROTO_VERSION into INIT_PROTO_VERSION and MIN_PEER_PROTO_VERSION

INIT_PROTO_VERSION is the initial version, after a succesful version/verack it is increased to a negotiated version.
MIN_PEER_PROTO_VERSION could be a different value to disconnect from peers older than a specified version.

1ce418929a

sipa commented at 9:51 AM on October 26, 2013: member

ACK

in src/version.h:None in 1ce418929a

  31 | -static const int MIN_PROTO_VERSION = 209;
  32 | +// intial proto version, to be increased after version/verack negotiation
  33 | +static const int INIT_PROTO_VERSION = 209;
  34 | +
  35 | +// disconnect from peers older than this proto version
  36 | +static const int MIN_PEER_PROTO_VERSION = 209;

sipa commented at 9:51 AM on October 26, 2013:

It could be initialized to INIT_PROTO_VERSION for now.

wtogami commented at 10:22 AM on October 26, 2013:

Sure, but the different number stresses that it can be changed independently? Your choice.

BitcoinPullTester commented at 10:00 AM on October 26, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/1ce418929a17c063a0a2e3b176b82d280ef053a6 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
jgarzik commented at 7:44 PM on October 27, 2013: contributor

ACK
wtogami commented at 8:52 AM on November 8, 2013: contributor

Anything stopping this? We have two core ACK's.
laanwj referenced this in commit 9a165e5714 on Nov 8, 2013
laanwj merged this on Nov 8, 2013
laanwj closed this on Nov 8, 2013
Bushstar referenced this in commit da2f503a48 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors