build: v28.1rc2 test/test_bitcoin-base58_tests.o errors on freebsd 14.2

grubles commented at 11:46 pm on December 20, 2024: contributor

Is there an existing issue for this?

I have searched the existing issues

Current behaviour

Running gmake errors when trying to build v28.1rc2 on FreeBSD 14.2:

 0% gmake
 1Making all in src
 2gmake[1]: Entering directory '/home/user/builds/bitcoin/src'
 3gmake[2]: Entering directory '/home/user/builds/bitcoin/src'
 4gmake[3]: Entering directory '/home/user/builds/bitcoin'
 5gmake[3]: Leaving directory '/home/user/builds/bitcoin'
 6  GEN      obj/build.h
 7  CXX      test/test_bitcoin-base58_tests.o
 8test/base58_tests.cpp:26:22: error: no matching function for call to 'read_json'
 9   26 |     UniValue tests = read_json(json_tests::base58_encode_decode);
10      |                      ^~~~~~~~~
11./test/util/json.h:12:10: note: candidate function not viable: no known conversion from 'const unsigned char[1462]' to 'const std::string' (aka 'const basic_string<char>') for 1st argument
12   12 | UniValue read_json(const std::string& jsondata);
13      |          ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~
14test/base58_tests.cpp:46:22: error: no matching function for call to 'read_json'
15   46 |     UniValue tests = read_json(json_tests::base58_encode_decode);
16      |                      ^~~~~~~~~
17./test/util/json.h:12:10: note: candidate function not viable: no known conversion from 'const unsigned char[1462]' to 'const std::string' (aka 'const basic_string<char>') for 1st argument
18   12 | UniValue read_json(const std::string& jsondata);
19      |          ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~
202 errors generated.
21gmake[2]: *** [Makefile:18443: test/test_bitcoin-base58_tests.o] Error 1
22gmake[2]: Leaving directory '/home/user/builds/bitcoin/src'
23gmake[1]: *** [Makefile:20315: all-recursive] Error 1
24gmake[1]: Leaving directory '/home/user/builds/bitcoin/src'
25gmake: *** [Makefile:755: all-recursive] Error 1

Expected behaviour

Build should complete

Steps to reproduce

Attempt to build v28.1rc2 on FreeBSD 14.2

Relevant log output

No response

How did you obtain Bitcoin Core

Compiled from source

What version of Bitcoin Core are you using?

v28.1rc2

Operating system and version

freebsd 14.2

Machine specifications

x86_64

grubles commented at 0:59 am on December 21, 2024: contributor

Huh false alarm I guess. I must not have done a clean rebuild.

 0  CXXLD    bitcoind
 1  CXXLD    bitcoin-cli
 2  CXXLD    bitcoin-tx
 3  CXXLD    bitcoin-wallet
 4  CXXLD    bitcoin-util
 5  CXXLD    test/fuzz/fuzz
 6  CXXLD    bench/bench_bitcoin
 7  CXXLD    test/test_bitcoin
 8gmake[2]: Leaving directory '/home/user/builds/bitcoin/src'
 9gmake[1]: Leaving directory '/home/user/builds/bitcoin/src'
10Making all in doc/man
11gmake[1]: Entering directory '/home/user/builds/bitcoin/doc/man'
12gmake[1]: Nothing to be done for 'all'.
13gmake[1]: Leaving directory '/home/user/builds/bitcoin/doc/man'
14gmake[1]: Entering directory '/home/user/builds/bitcoin'
15gmake[1]: Nothing to be done for 'all-am'.
16gmake[1]: Leaving directory '/home/user/builds/bitcoin'

grubles closed this on Dec 21, 2024

build: v28.1rc2 test/test_bitcoin-base58_tests.o errors on freebsd 14.2 #31550