depends: Update capnproto to 1.1.0 #31552

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:241221-capnp changing 1 files +2 −2
  1. hebasto commented at 5:53 pm on December 21, 2024: member

    This change fixes compilation on NetBSD with GCC 14:

     0$ gmake -C depends capnp MULTIPROCESS=1 CC=/usr/pkg/gcc14/bin/gcc CXX=/usr/pkg/gcc14/bin/g++
     1gmake: Entering directory '/home/hebasto/dev/bitcoin/depends'
     2<snip>
     3In file included from /home/hebasto/dev/bitcoin/depends/work/build/x86_64-unknown-netbsd10.0/capnp/1.0.2-ffdefffd9f5/src/kj/memory.h:24,
     4                 from /home/hebasto/dev/bitcoin/depends/work/build/x86_64-unknown-netbsd10.0/capnp/1.0.2-ffdefffd9f5/src/kj/exception.h:24,
     5                 from /home/hebasto/dev/bitcoin/depends/work/build/x86_64-unknown-netbsd10.0/capnp/1.0.2-ffdefffd9f5/src/kj/async-prelude.h:27,
     6                 from /home/hebasto/dev/bitcoin/depends/work/build/x86_64-unknown-netbsd10.0/capnp/1.0.2-ffdefffd9f5/src/kj/async.h:24,
     7                 from /home/hebasto/dev/bitcoin/depends/work/build/x86_64-unknown-netbsd10.0/capnp/1.0.2-ffdefffd9f5/src/kj/async-io.h:24,
     8                 from /home/hebasto/dev/bitcoin/depends/work/build/x86_64-unknown-netbsd10.0/capnp/1.0.2-ffdefffd9f5/src/kj/async-io-unix.c++:35:
     9/home/hebasto/dev/bitcoin/depends/work/build/x86_64-unknown-netbsd10.0/capnp/1.0.2-ffdefffd9f5/src/kj/async-io-unix.c++: In lambda function:
    10/home/hebasto/dev/bitcoin/depends/work/build/x86_64-unknown-netbsd10.0/capnp/1.0.2-ffdefffd9f5/src/kj/async-io-unix.c++:1243:24: error: 'AI_V4MAPPED' was not declared in this scope
    11 1243 |       hints.ai_flags = AI_V4MAPPED | AI_ADDRCONFIG;
    12      |                        ^~~~~~~~~~~
    13gmake[3]: *** [src/kj/CMakeFiles/kj-async.dir/build.make:146: src/kj/CMakeFiles/kj-async.dir/async-io-unix.c++.o] Error 1
    14gmake[2]: *** [CMakeFiles/Makefile2:203: src/kj/CMakeFiles/kj-async.dir/all] Error 2
    15gmake[1]: *** [Makefile:136: all] Error 2
    16gmake[1]: Leaving directory '/home/hebasto/dev/bitcoin/depends/work/build/x86_64-unknown-netbsd10.0/capnp/1.0.2-ffdefffd9f5'
    17gmake: *** [funcs.mk:302: /home/hebasto/dev/bitcoin/depends/work/build/x86_64-unknown-netbsd10.0/capnp/1.0.2-ffdefffd9f5/./.stamp_built] Error 2
    18gmake: Leaving directory '/home/hebasto/dev/bitcoin/depends'
    

    See: https://github.com/capnproto/capnproto/commit/ccaa1f87c1c8cc289a088e9c508323c51bd638cf.

    However, the other changes between v1.0.2 and v1.1.0 require a sanity check.

  2. depends: Update capnproto to 1.1.0
    This change fixes compilation on NetBSD with GCC 14.
    b0b8d96d93
  3. hebasto added the label Build system on Dec 21, 2024
  4. DrahtBot commented at 5:53 pm on December 21, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31552.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hodlinator

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. hodlinator approved
  6. hodlinator commented at 3:25 pm on January 2, 2025: contributor

    cr-ACK b0b8d96d93ea4971e7941ddca03f4393deaac293

    Verified hash:

    0₿ curl https://capnproto.org/capnproto-c++-1.1.0.tar.gz -o summed_file
    1₿ sha256sum summed_file
    207167580e563f5e821e3b2af1c238c16ec7181612650c5901330fa9a0da50939  summed_file
    

    Cloned repo from GH and ran:

    0₿ git diff v1.0.2 v1.1.0
    1+
    2₿ git range-diff v2 v1.0.2 v1.1.0
    

    Fairly minor changes. Adding some extra metadata for LSPs, disabling Android CI, some platform specific bugfixes and features, zlib dependency update.

  7. fanquake merged this on Jan 6, 2025
  8. fanquake closed this on Jan 6, 2025

  9. hebasto deleted the branch on Jan 6, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-01-21 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me