test: Move `script_assets_tests` into its own suite

hebasto commented at 7:28 pm on December 27, 2024: member

This PR ensures that the script_assets_tests test case is explicitly reported as “Skipped” when it is not run, making it clearer when running the test suite with ctest:

on the master branch @ 9355578a77978a0c2f189bd7315a2883142d8119:

 0$ env -u DIR_UNIT_TEST_DATA ctest --test-dir build -j 16 -R "^script_"
 1Internal ctest changing into directory: /home/hebasto/git/bitcoin/build
 2Test project /home/hebasto/git/bitcoin/build
 3    Start 87: script_tests
 4    Start 83: script_p2sh_tests
 5    Start 85: script_segwit_tests
 6    Start 86: script_standard_tests
 7    Start 84: script_parse_tests
 81/5 Test [#84](/bitcoin-bitcoin/84/): script_parse_tests ...............   Passed    0.11 sec
 92/5 Test [#86](/bitcoin-bitcoin/86/): script_standard_tests ............   Passed    0.11 sec
103/5 Test [#85](/bitcoin-bitcoin/85/): script_segwit_tests ..............   Passed    0.12 sec
114/5 Test [#83](/bitcoin-bitcoin/83/): script_p2sh_tests ................   Passed    0.12 sec
125/5 Test [#87](/bitcoin-bitcoin/87/): script_tests .....................   Passed    0.36 sec
13
14100% tests passed, 0 tests failed out of 5
15
16Total Test time (real) =   0.37 sec

with this PR:

 0$ env -u DIR_UNIT_TEST_DATA ctest --test-dir build -j 16 -R "^script_"
 1Internal ctest changing into directory: /home/hebasto/git/bitcoin/build
 2Test project /home/hebasto/git/bitcoin/build
 3    Start 83: script_assets_tests
 4    Start 88: script_tests
 5    Start 84: script_p2sh_tests
 6    Start 86: script_segwit_tests
 7    Start 87: script_standard_tests
 8    Start 85: script_parse_tests
 91/6 Test [#85](/bitcoin-bitcoin/85/): script_parse_tests ...............   Passed    0.11 sec
102/6 Test [#83](/bitcoin-bitcoin/83/): script_assets_tests ..............***Skipped   0.12 sec
113/6 Test [#86](/bitcoin-bitcoin/86/): script_segwit_tests ..............   Passed    0.11 sec
124/6 Test [#87](/bitcoin-bitcoin/87/): script_standard_tests ............   Passed    0.11 sec
135/6 Test [#84](/bitcoin-bitcoin/84/): script_p2sh_tests ................   Passed    0.12 sec
146/6 Test [#88](/bitcoin-bitcoin/88/): script_tests .....................   Passed    0.36 sec
15
16100% tests passed, 0 tests failed out of 6
17
18Total Test time (real) =   0.37 sec
19
20The following tests did not run:
21	 83 - script_assets_tests (Skipped)
22$ env DIR_UNIT_TEST_DATA=/home/hebasto/git/bitcoin/qa-assets/unit_test_data ctest --test-dir build -j 16 -R "^script_"
23Internal ctest changing into directory: /home/hebasto/git/bitcoin/build
24Test project /home/hebasto/git/bitcoin/build
25    Start 83: script_assets_tests
26    Start 88: script_tests
27    Start 84: script_p2sh_tests
28    Start 86: script_segwit_tests
29    Start 87: script_standard_tests
30    Start 85: script_parse_tests
311/6 Test [#85](/bitcoin-bitcoin/85/): script_parse_tests ...............   Passed    0.11 sec
322/6 Test [#87](/bitcoin-bitcoin/87/): script_standard_tests ............   Passed    0.11 sec
333/6 Test [#86](/bitcoin-bitcoin/86/): script_segwit_tests ..............   Passed    0.11 sec
344/6 Test [#84](/bitcoin-bitcoin/84/): script_p2sh_tests ................   Passed    0.12 sec
355/6 Test [#88](/bitcoin-bitcoin/88/): script_tests .....................   Passed    0.35 sec
366/6 Test [#83](/bitcoin-bitcoin/83/): script_assets_tests ..............   Passed    1.58 sec
37
38100% tests passed, 0 tests failed out of 6
39
40Total Test time (real) =   1.58 sec

hebasto added the label Tests on Dec 27, 2024

DrahtBot commented at 7:28 pm on December 27, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31576.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#32080 (OP_CHECKCONTRACTVERIFY by bigspider)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

hebasto marked this as a draft on Dec 27, 2024

test: Move `script_assets_tests` into its own suite

This change ensures that the `script_assets_tests` test case is
explicitly reported as "Skipped" when it is not run, making it clearer
when running the test suite with `ctest`.

0859fc22f0

hebasto force-pushed on Dec 27, 2024

hebasto marked this as ready for review on Dec 27, 2024

hebasto commented at 3:01 pm on January 7, 2025: member

See the use case in https://github.com/hebasto/bitcoin-core-nightly/pull/27.

hebasto commented at 9:54 am on February 10, 2025: member

Friendly ping @maflcko ;)

maflcko commented at 5:17 pm on February 25, 2025: member

Seems fine. No strong opinion.

test: Move script_assets_tests into its own suite #31576

Code Coverage & Benchmarks

Reviews

Conflicts

test: Move `script_assets_tests` into its own suite #31576