DecodeBase58 and DecodeBase58Check are fuzzed with a fixed value for max_ret_len (100). However, different values are used for this parameter depending on the usage (see key_io and unit tests).
fuzz: fuzz `max_ret_len` for `DecodeBase58`/`DecodeBase58Check` #31577
pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2024-12-fuzz-base-encode-decode changing 1 files +6 −3-
brunoerg commented at 9:02 PM on December 27, 2024: contributor
-
28187098c9
fuzz: fuzz `max_ret_len` for `DecodeBase58`/`DecodeBase58Check`
The value of `max_ret_len` is hardcoded (100). However, different values are used for this parameter depending on the usage.
-
DrahtBot commented at 9:02 PM on December 27, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31577.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
- DrahtBot added the label Tests on Dec 27, 2024
-
l0rinc commented at 9:12 PM on December 27, 2024: contributor
~Would it make sense to extend #30746 instead?~ Edit: extended
a32002f(#30746) with this. -
l0rinc commented at 9:18 PM on December 27, 2024: contributor
Moved the change over, added you as a co-author - thanks
- brunoerg closed this on Dec 27, 2024
- bitcoin locked this on Dec 27, 2025