ci: Switch to latest macOS and Windows images #31597

1. 
   hebasto commented at 9:04 am on January 3, 2025: member

   This PR updates the macOS and Windows images to their latest versions, in line with our usual practice.

   Additionally, the Xcode version has been updated to 16.2.

   For more details regarding these images, please refer to:

   • https://github.com/actions/runner-images/issues/10686
   • https://github.com/actions/runner-images/issues/11228
2. hebasto added the label Tests on Jan 3, 2025
3. 
   DrahtBot commented at 9:04 am on January 3, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31597.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. in .github/workflows/ci.yml:114 in af71c952b4 outdated

   110@@ -111,7 +111,7 @@ jobs:
   111 
   112       - name: Clang version
   113         run: |
   114-          sudo xcode-select --switch /Applications/Xcode_15.0.app
   115+          sudo xcode-select --switch /Applications/Xcode_16.2.0.app
   

   ---

   ---

   

   maflcko commented at 12:05 pm on January 3, 2025:

   Not sure about this. This should be the minimum version supported. IIRC xcode 15 corresponds to clang-16, somewhat?

   If you want to test the latest xcode version, you can add a different task here, or in a nightly repo.

   Otherwise, the build may break silently for xcode 15 and users/devs will complain.

   ---

   

   hebasto commented at 2:47 pm on January 3, 2025:

   IIRC xcode 15 corresponds to clang-16, somewhat?

   That’s correct.

   ---

   

   hebasto commented at 2:53 pm on January 3, 2025:

   Not sure about this. This should be the minimum version supported.

   Reverted back to Xcode 15.

5. maflcko changes_requested
6. 
   maflcko commented at 12:06 pm on January 3, 2025: member

   not sure about this. Is there a reason to do this?
7. ci: Switch to latest macOS and Windows images 9c86a56236
8. hebasto force-pushed on Jan 3, 2025
9. 
   hebasto commented at 2:52 pm on January 3, 2025: member

   not sure about this. Is there a reason to do this?

   https://github.com/bitcoin/bitcoin/blob/6aa0e70ccbd5491ec9d7c81892820f3341ccd631/.github/workflows/ci.yml#L79

   and

   https://github.com/bitcoin/bitcoin/blob/6aa0e70ccbd5491ec9d7c81892820f3341ccd631/.github/workflows/ci.yml#L151

   Alternatively, these comments should be removed.

10. 
    maflcko commented at 3:39 pm on January 3, 2025: member

    Alternatively, these comments should be removed.

    Makes sense to remove the comment and explain that the xcode version is supposed to denote the minimum supported version to compile from xcode. I presume this is equal to https://github.com/bitcoin/bitcoin/blame/6aa0e70ccbd5491ec9d7c81892820f3341ccd631/doc/release-notes-empty-template.md#L46, where 13.0+, means 13+. I assume that anyone on 13.0 is able to, and must upgrade to the latest 13.x anyway, so that the minimum requirement is not an issue. See “Xcode 15 requires a Mac running macOS Ventura 13.5 or later.” (https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes)

11. 
    hebasto commented at 3:03 pm on January 4, 2025: member

    @maflcko

    Alternatively, these comments should be removed.

    Makes sense to remove the comment and explain that the xcode version is supposed to denote the minimum supported version to compile from xcode. I presume this is equal to https://github.com/bitcoin/bitcoin/blame/6aa0e70ccbd5491ec9d7c81892820f3341ccd631/doc/release-notes-empty-template.md#L46, where 13.0+, means 13+. I assume that anyone on 13.0 is able to, and must upgrade to the latest 13.x anyway, so that the minimum requirement is not an issue. See “Xcode 15 requires a Mac running macOS Ventura 13.5 or later.” (https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes)

    Mind picking this up?

12. 
    maflcko commented at 9:10 am on January 6, 2025: member

    Mind picking this up?

    Sure, see https://github.com/bitcoin/bitcoin/pull/31608

13. fanquake closed this on Jan 6, 2025

    ---

Contributors
hebasto DrahtBot maflcko

Labels
Tests