#31403 follow-up #31598

pull yuvicc wants to merge 2 commits into bitcoin:master from yuvicc:2025-01-pr-31403 changing 2 files +10 −10

yuvicc commented at 1:25 pm on January 3, 2025: contributor
#31403 follow-up, see comment
- Rename invalid_call parameter to called_by_framework in generateblock, generatetoaddress and generatetodescriptor mining methods to better express its intended usage.
- Add explicit assertion message clarifying that these functions should only be called by TestFramework itself to maintain proper node synchronization.
test: improve rogue calls in mining functions f76da67ca0
Merge branch 'bitcoin:master' into 2025-01-pr-31403 51a60faafa
DrahtBot commented at 1:25 pm on January 3, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31598.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
yuvicc closed this on Jan 3, 2025
yuvicc deleted the branch on Jan 3, 2025
bitcoin locked this on Jan 3, 2026