qa: Improve framework.generate* enforcement (#31403 follow-up) #31599

1. 
   i-am-yuvi commented at 1:41 pm on January 3, 2025: none

   #31403 follow-up, see comment

   • Rename invalid_call parameter to called_by_framework in generateblock, generatetoaddress and generatetodescriptor mining methods to better express its intended usage.
   • Add explicit assertion message clarifying that these functions should only be called by TestFramework itself to maintain proper node synchronization.
2. 
   DrahtBot commented at 1:42 pm on January 3, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31599.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hodlinator, maflcko, Prabhat1308

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Tests on Jan 3, 2025
4. i-am-yuvi renamed this:
   test: improve rogue calls in mining functions
   #31403 follow-up
   on Jan 3, 2025
5. hodlinator approved
6. 
   hodlinator commented at 10:14 am on January 6, 2025: contributor

   ACK a3f5573ae3aa5edbe92d0388f36586ad02214de6

   First commit follows recommendations by myself with improvements by maflcko in already merged PR.

   Passed subset of functional tests locally.

   ---

   Might squeeze a little bit more information into the title?

   “#31403 follow-up” -> “qa: Improve framework.generate* enforcement (#31403 follow-up)”

   See https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#creating-the-pull-request

7. 
   maflcko commented at 10:33 am on January 6, 2025: member

   Also, a rebase would be good
8. 
   i-am-yuvi commented at 3:31 pm on January 6, 2025: none

   ACK a3f5573

   First commit follows recommendations by myself with improvements by maflcko in already merged PR.

   Passed subset of functional tests locally.

   Might squeeze a little bit more information into the title?

   “#31403 follow-up” -> “qa: Improve framework.generate* enforcement (#31403 follow-up)”

   See https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#creating-the-pull-request

   Thanks!

9. i-am-yuvi renamed this:
   #31403 follow-up
   qa: Improve framework.generate* enforcement (#31403 follow-up)
   on Jan 6, 2025
10. test: improve rogue calls in mining functions 1b51616f2e
11. i-am-yuvi force-pushed on Jan 6, 2025
12. 
    i-am-yuvi commented at 5:02 pm on January 6, 2025: none

    Also, a rebase would be good

    Done!

13. hodlinator approved
14. 
    hodlinator commented at 9:42 am on January 7, 2025: contributor

    re-ACK 1b51616f2e3b58a1c63a19e6dba8e7e9c2aefdeb

    0₿ git range-diff master a3f5573^ 1b51616
    1...
    226:  b3100b02c5 = 40:  1b51616f2e test: improve rogue calls in mining functions
    

    (Second commit dropped due to typo being fixed in master).

    Thanks for adjusting the PR title!

15. 
    maflcko commented at 1:29 pm on January 9, 2025: member

    lgtm ACK 1b51616f2e3b58a1c63a19e6dba8e7e9c2aefdeb
16. 
    Prabhat1308 commented at 7:46 pm on January 17, 2025: none

    ACK 1b51616

Contributors
i-am-yuvi DrahtBot hodlinator maflcko Prabhat1308

Labels
Tests