build, test: Build db_tests.cpp regardless of USE_BDB #31617

1. 
   hebasto commented at 4:06 pm on January 7, 2025: member

   When the building of db_tests.cpp was made conditional on USE_BDB in commit a58b719cf75e2d97205ec260bcff0d4780fe4fb8, all db_tests were indeed specific to BDB wallets.

   However, the tests have since been extended to include SQLite wallets as well.

   On the master branch @ 433412fd8478923dfdb20044f74c5d1e19fa8dd8, tests specific to SQLite wallets are not built and run if configured with WITH_BDB=OFF (the default option).

   This PR resolves this issue by guarding BDB-specific code in db_tests.cpp and ensuring this source file is compiled regardless of the WITH_BDB option.

2. build, test: Build `db_tests.cpp` regardless of `USE_BDB`

   While some tests are specific to BDB, `db_tests` as a whole are not
   limited to BDB.

   fd2d96d908
3. hebasto added the label Wallet on Jan 7, 2025
4. hebasto added the label Build system on Jan 7, 2025
5. hebasto added the label Tests on Jan 7, 2025
6. 
   DrahtBot commented at 4:06 pm on January 7, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31617.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	achow101, maflcko, theuni

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #31250 (wallet: Disable creating and loading legacy wallets by achow101)
   • #28710 (Remove the legacy wallet and BDB dependency by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   achow101 commented at 8:15 pm on January 7, 2025: member

   ACK fd2d96d9087be234bdf4a6eb6d563e92b4fb4501
8. 
   maflcko commented at 11:38 am on January 8, 2025: member

   review ACK fd2d96d9087be234bdf4a6eb6d563e92b4fb4501 🔺

   Signature:

   0untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
   1RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
   2trusted comment: review ACK fd2d96d9087be234bdf4a6eb6d563e92b4fb4501 🔺
   3PudR0SSJoyMDW68OGxLLO+dNPsG2ndaBeyPx6wu/0EHelBh9w4j9Qjf99ycJXvW9t9/X7x5wEuZLSDWPSN1/AQ==
   

9. theuni approved
10. 
    theuni commented at 4:04 pm on January 8, 2025: member

    utACK fd2d96d9087be234bdf4a6eb6d563e92b4fb4501
11. achow101 merged this on Jan 9, 2025
12. achow101 closed this on Jan 9, 2025

    ---

13. hebasto deleted the branch on Jan 10, 2025

Contributors
hebasto DrahtBot achow101 maflcko theuni

Labels
Wallet Build system Tests